Reduce test verbosity in arp.rs TODO #4600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andr3wy
force-pushed
the
3273-2
branch
2 times, most recently
from
1a66088
to
8303d40
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4600 +/- ##
=======================================
Coverage 82.13% 82.13%
=======================================
Files 255 255
Lines 31267 31267
=======================================
Hits 25682 25682
Misses 5585 5585
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andr3wy
force-pushed
the
3273-2
branch
2 times, most recently
from
57fb051
to
d2788c6
Compare
|
Style resolved and commits squashed. |
In arp, there was originally lots of repetitive code. This was removed. Signed-off-by: Andrew Yao <andr3wy@gmail.com>
roypat
added
the
Status: Awaiting review
zulinx86
approved these changes
May 8, 2024
roypat
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Repetitively redefined different ARP requests were streamlined the code to be more generalized, shorter, and easier to follow, by refactoring the code.
...
Reason
Address a TODO regarding the verbosity of the tests. See #3273
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.