Rollup of stale PRs

src/vmm/src/devices/virtio/queue.rs

@@ -94,8 +94,10 @@
         let desc = match mem.read_obj::<Descriptor>(desc_head) {
             Ok(ret) => ret,
             Err(err) => {
-                // TODO log address
-                error!("Failed to read virtio descriptor from memory: {}", err);
+                error!(
+                    "Failed to read virtio descriptor from memory at address {:#x}: {}",
+                    desc_head.0, err
+                );
                 return None;
             }
         };

src/vmm/src/dumbo/tcp/endpoint.rs

@@ -81,13 +81,23 @@ pub struct Endpoint {
 // is the only option).
 
 impl Endpoint {
+    /// Creates a new Endpoint from a [`crate::tcp::connection::Connection`]
+    /// ## Arguments:
+    /// - `segment`: The incoming `SYN`.
+    /// - `eviction_threshold`: CPU cycles that must elapse before this Endpoint is evictable
+    /// - `connection_rto_period`: How long the connection waits before a retransmission timeout
+    ///   fires for the first segment which has not been acknowledged yet. This uses an opaque time
+    ///   unit.
+    /// - `connection_rto_count_max`: How many consecutive timeout-based retransmission may occur
+    ///   before the connection resets itself.
+    /// ## Panics:
+    /// - `assert!(RCV_BUF_MAX_SIZE <= MAX_WINDOW_SIZE as usize);`
     pub fn new<T: NetworkBytes + Debug>(
         segment: &TcpSegment<T>,
         eviction_threshold: NonZeroU64,
         connection_rto_period: NonZeroU64,
         connection_rto_count_max: NonZeroU16,
     ) -> Result<Self, PassiveOpenError> {
-        // TODO: mention this in doc comment for function
         // This simplifies things, and is a very reasonable assumption.
         #[allow(clippy::assertions_on_constants)]
         {

src/vmm/src/logger/metrics.rs

@@ -94,8 +94,6 @@ pub struct Metrics<T: Serialize, M: Write + Send> {
 
 impl<T: Serialize + Debug, M: Write + Send + Debug> Metrics<T, M> {
     /// Creates a new instance of the current metrics.
-    // TODO: We need a better name than app_metrics (something that says that these are the actual
-    // values that we are writing to the metrics_buf).
     pub const fn new(app_metrics: T) -> Metrics<T, M> {
         Metrics {
             metrics_buf: OnceLock::new(),