Add support for HTTP Delete method #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Method::Delete, which is needed for device hot-removal. Also fix a clippy warning. Fixes: firecracker-microvm#12 Signed-off-by: Liu Jiang <gerry@linux.alibaba.com>
| @@ -150,6 +150,8 @@ pub enum Method { | |||
| Put, | |||
| /// PATCH Method. | |||
| Patch, | |||
| /// Delete Method. | |||
There was a problem hiding this comment.
nit: /// DELETE Method.
|
+1, Also we need to add these commonly used methods: |
This was referenced Oct 30, 2020
|
closed in preferred of #17 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for This PR
#12
Description of Changes
Add support for Method::Delete, which is needed for device hot-removal.
Also fix a clippy warning.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).unsafecode is properly documented.CHANGELOG.md.