disco/choreo: parsing, generating vote transactions; echoing gossip vote transactions #1925
Conversation
yhzhangjump
force-pushed
the
yunzhang/feat/gossip-echo-vote-txns
branch
from
13b31f3
to
18d06c3
Compare
yhzhangjump
force-pushed
the
yunzhang/feat/gossip-echo-vote-txns
branch
from
18d06c3
to
a1c17e3
Compare
|
The program for echoing vote transactions works. This PR is still in progress -- I will add a library in |
yhzhangjump
changed the title
| + FD_TXN_ACCT_ADDR_SZ * program_id ); | ||
|
|
||
| if ( memcmp( program_account_addr, fd_solana_vote_program_id.key, sizeof( fd_pubkey_t ) ) ) { | ||
| FD_LOG_WARNING( ("fd_vote_txn_parse: txn targets program %32J instead of %32J", |
There was a problem hiding this comment.
%32J doesn't work anymore
There was a problem hiding this comment.
Ah, good to know. Are you suggesting that I should remove 32J here? Do we have an alternative for printing hash values then?
There was a problem hiding this comment.
If you really need it, use
#pragma GCC diagnostic ignored "-Wformat"
#pragma GCC diagnostic ignored "-Wformat-extra-args"
for debugging
There was a problem hiding this comment.
Right, I have them here: https://github.com/firedancer-io/firedancer/pull/1925/files#diff-c2df46d55326a4c2437845547d03a6cedd76bbbf8b568f6de7a0416efa60dd2fR3
Is this fine? Do you mean that I should avoid using "%32J" in real production (as opposed to debug)?
yhzhangjump
force-pushed
the
yunzhang/feat/gossip-echo-vote-txns
branch
from
05096b1
to
6374b8f
Compare
| + FD_TXN_ACCT_ADDR_SZ * program_id ); | ||
|
|
||
| if ( memcmp( program_account_addr, fd_solana_vote_program_id.key, sizeof( fd_pubkey_t ) ) ) { | ||
| FD_LOG_WARNING( ("fd_vote_txn_parse: txn targets program %32J instead of %32J", |
There was a problem hiding this comment.
If you really need it, use
#pragma GCC diagnostic ignored "-Wformat"
#pragma GCC diagnostic ignored "-Wformat-extra-args"
for debugging
| ushort vote_instr_size = (ushort)fd_vote_instruction_size( &vote_instr ); | ||
|
|
||
| uchar instr_accounts[2]; | ||
| instr_accounts[0] = 1; /* vote account */ |
There was a problem hiding this comment.
both instr accounts are the same?
There was a problem hiding this comment.
This is the case for local agave validator. Testnet does have 2 different accounts and I will work on adapting to testnet validator next.
There was a problem hiding this comment.
I know this PR is old, but I wish to let you know that your concern here has been addressed in my latest PR #2059. It turns out that there is a bug in solana-test-validator which causes their vote txn to have this issue.
yhzhangjump
force-pushed
the
yunzhang/feat/gossip-echo-vote-txns
branch
from
6374b8f
to
c8cd498
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
arjain4
force-pushed
the
yunzhang/feat/gossip-echo-vote-txns
branch
from
c8cd498
to
82c67fa
Compare
yhzhangjump
force-pushed
the
yunzhang/feat/gossip-echo-vote-txns
branch
from
82c67fa
to
0d9969c
Compare
…nsactions through gossip
arjain4
force-pushed
the
yunzhang/feat/gossip-echo-vote-txns
branch
from
0d9969c
to
5ef9bdd
Compare
No description provided.