Passe empty string to <input> when date is null #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firedev
reviewed
Jan 4, 2017
| @@ -95,24 +95,12 @@ var DateInput = React.createClass({ | |||
| }, | |||
|
|
|||
| render () { | |||
| const { | |||
There was a problem hiding this comment.
@ruianderson Wouldn't removing this hunk cause other warnings for unknown props?
There was a problem hiding this comment.
I had troubles to build the code locally and I had to remove this piece of code. I can revert if it's needed.
There was a problem hiding this comment.
It would be best I think, this was added to get rid of other warnings.
There was a problem hiding this comment.
👍 I removed the code and let only the value changes.
This will avoid an error when trying to pass null to <input> value
ruianderson
force-pushed
the
fix-input-value
branch
from
ea4f008
to
a73cad8
Compare
firedev
reviewed
Jan 11, 2017
| return <input | ||
| ref='input' | ||
| type='text' | ||
| {...inputProps} | ||
| value={this.state.maybeDate} | ||
| value |
There was a problem hiding this comment.
This was incorrect. I've fixed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will avoid an error when trying to pass null to value: