better error checking

firefart · Dec 29, 2022 · af0b1a6 · af0b1a6
1 parent e2fbd4e
commit af0b1a6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/internal/stun.go b/internal/stun.go
@@ -22,6 +22,18 @@ func (s *Stun) GetErrorString() string {
 	for _, a := range s.Attributes {
 		if a.Type == AttrErrorCode {
 			attrError := ParseError(a.Value)
+			// update error text if server did not provide one
+			if len(strings.TrimSpace(attrError.ErrorText)) == 0 {
+				if tmp, ok := StunErrorNames[attrError.ErrorCode]; ok {
+					attrError.ErrorText = tmp
+				} else if tmp, ok := TurnErrorNames[attrError.ErrorCode]; ok {
+					attrError.ErrorText = tmp
+				} else if tmp, ok := TurnTCPErrorNames[attrError.ErrorCode]; ok {
+					attrError.ErrorText = tmp
+				} else {
+					attrError.ErrorText = "Invalid Error"
+				}
+			}
 			return fmt.Sprintf("Error %d: %s", attrError.ErrorCode, attrError.ErrorText)
 		}
 	}

diff --git a/internal/types_stun.go b/internal/types_stun.go
@@ -372,7 +372,7 @@ const (
 )
 
 // nolint:deadcode,varcheck,unused
-var errorNames = map[ErrorCode]string{
+var StunErrorNames = map[ErrorCode]string{
 	ErrorTryAlternate:               "Try Alternate",
 	ErrorBadRequest:                 "Bad Request",
 	ErrorUnauthorized:               "Unauthorized",