Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rules are not executed on FinTS import #2081

Closed
joshwapohlmann opened this issue Feb 12, 2019 · 5 comments
Closed

Rules are not executed on FinTS import #2081

joshwapohlmann opened this issue Feb 12, 2019 · 5 comments
Labels
enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release).

Comments

@joshwapohlmann
Copy link

Bug description
I am running Firefly III version 4.7.10.
Whenever I import bank statements via FinTS my rules are not applied to the imported data.
I checked if rules "find" their corresponding and they match successfully. However, apparently none are executed.

Steps to reproduce

  1. Create rules which trigger whenever a transaction is created
  2. Make sure it matches one or more of the transaction to be imported
  3. Import any number of transactions with FinTS
  4. The rule (nor any other) was not applied on any transaction

Expected behavior
Rules with matching transactions should be executed.

Extra info
I will add Logs as soon as I have any new transactions I can test this against
@JC5
Copy link
Member

JC5 commented Feb 12, 2019

Hi! This is a canned reply that tells you how to get more debug details.

  1. Please collect some log files. Go to storage/logs and open the latest log file. It should be called something like "ff3-fpm-fcgi-*.log". In it, you should be able to find the error along with its "stacktrace": this will tell me where Firefly III broke down. If you run Docker, use docker logs <container.
  2. You may also enable debug mode to make sure the log files catch everything and try again.
  3. Make sure you clear your browser cookies and clear Firefly III's cache files by running php artisan cache:clear or by visiting /flush on your installation.

If you do not want to share log files or other details on Github, please send them to me over (encrypted) email.

@JC5
Copy link
Member

JC5 commented Feb 12, 2019

I'm pretty sure the FinTS import routine doesn't ask to apply rules. Hence, they aren't. I'll check if I can safely add it. I can't test this so I'm flying blind.

JC5 added a commit that referenced this issue Feb 13, 2019
@JC5
Add thing to apply rules to fints #2081
2117fc2
@joshwapohlmann
Copy link
Author

I recklessly applied the patch to my 4.7.10 installation.

  1. The checkbox added is shown properly
  2. No errors occur
  3. rules are applied correctly (matching process shows up in the log and is reflected in the results).

I'd say commit 2117fc2 is a success and closes this issue.

@JC5 JC5 added enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release). and removed possible bug labels Feb 15, 2019
@JC5
Copy link
Member

JC5 commented Feb 15, 2019

Glad to hear it 👍. I'll close the issue when the new release is live.

@JC5 JC5 closed this as completed Feb 16, 2019
@JC5
Copy link
Member

JC5 commented Feb 16, 2019

4.7.12 has been released. Follow the status of the Docker build on Travis CI.

JC5 added a commit that referenced this issue Feb 16, 2019
@JC5
Merge branch 'develop' into layoutv2
4fe9cec 
* develop: (26 commits)
  Slight change in build script.
  Updated meta files.
  New translations.
  Final touches for #2085
  Extra debug log. #2061
  Fix build script.
  Apply fix for #2070
  Fix for #2070
  Various code cleanup.
  Updates to the login procedure [skip ci]
  Push and build stuff.
  Update LDAP config for #2085
  Updated LDAP code #2085
  Fix issue with upgrade.
  Add required PHP extensions to composer.json.
  Code cleaning stuff.
  Fix for #2082
  First part of a large code cleanup commit.
  Update version.
  Add thing to apply rules to fints #2081
  ...
hamuz pushed a commit to hamuz/firefly-iii that referenced this issue Feb 23, 2019
@JC5 @hamuz
Add thing to apply rules to fints firefly-iii#2081
3a847c9
@patago patago mentioned this issue Mar 12, 2019
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JC5 @joshwapohlmann