[EditorSearch] Polish Search

[wldcordeiro]

Checklist:

• Clearing the query to an empty string causes a search of empty text.
• the search index starts at 1 and always increments by 1 [EditorSearch] Fix search results count #1967
• deleting the query does not clear the last match
• white space queries breaks the editor
• queries increment the searches [EditorSearch] search increments as you type #2046
• can't delete the last letter of the query
• clicking in the document does not update the search index [EditorSearch] clicking in the document does not update the search index #2065
• Editor Search breaks with "whole word" modifier and query's of 3 or less characters [EditorSearch] breaks with "whole word" modifier and query's of 3 or less characters #2105
• escape should always close the search bar [EditorSearch] escape should always close the search bar #2104 @nchevobbe
• cmd+f without a selection should refocus the search bar [EditorSearch] cmd+f without a selection should refocus the search bar #2103
• search jumps [Editor] alignLine misreads the start location #2081
• Add integration tests [EditorSearch] add an integration test #1928
• move search state to UI reducer [EditorSearch] move search state to UI reducer #2126
• Add search bottom bar [EditorSearch] Add search bottom bar #2078
• Refactor search components to better support function search in editor. [EditorSearch][FunctionSearch] Combine UI and refactor search components #2151
• doSearch slowness [EditorSearch] doSearch is slow #2154
• Only do one search type [EditorSearch/FunctionSearch] Ensure only one type of search occurs #2171
• polish overlays [EditorSearch] polish overlays  #2228

[arthur801031]

I'll take a stab at "Clearing the query to an empty string causes a search of empty text.".

[arthur801031]

Hi @wldcordeiro!

I can't reproduce this bug: "Clearing the query to an empty string causes a search of empty text". Please let me know how to reproduce it. Thank you! 😀

[jasonLaster]

Thanks @arthur801031. I couldn't find that either. But it did help me find two others :)

• deleting the query does not clear the last match
• white space queries breaks the editor

[arthur801031]

Hi @jasonLaster @wldcordeiro

For "deleting the query does not clear the last match" bug, the Chrome debugger also has this behavior, but it changes the highlight color for the last character/string that was cleared. Maybe we should change the yellow to something else?

[jasonLaster]

closing this as we've done all of the big work here