[Editor] alignLine misreads the start location

[jasonLaster]

I've noticed that while searching the editor can occassionally be a bit jumpy. The reason for this is that the editor thinks that the new search result is not visible and centers the result in the middle of the editor.

This is a bug in how we calculate the start and last visible line of the document: here

Here are some screenshots of searching where the match is visible, but codemirror thinks it's not:

One other thought, this is likely CSS and could work on firefox, but fail on chrome

search

alignLine

[rrandom]

Hi, @jasonLaster , I found that set "viewportMargin": Infinity when create the editor instance will fix this. But it's not recommend by Codemirror https://codemirror.net/doc/manual.html#option_viewportMargin

[jasonLaster]

Hmm nice find. Let's see if that fixes it. The problem is in chrome but not Firefox

…

On Fri, Mar 3, 2017 at 7:50 AM Rrrandom ***@***.***> wrote: Hi, @jasonLaster <https://github.com/jasonLaster> , I found that set "viewportMargin": Infinity when create the editor instance will fix this. But it's not recommend by Codemirror https://codemirror.net/doc/manual.html#option_viewportMargin — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2081 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPiYo6pT_C0WAZWRvGkynC-rYfdRd4Lks5riAx_gaJpZM4MJPWM> .

[jasonLaster]

I think this is fixed by firefox-devtools/devtools-core#515