Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

fixing issue where react = react-dom #1731

Merged
merged 2 commits into from
Jan 17, 2017

Conversation

amitmtrn
Copy link
Contributor

Associated Issue: #1640

Summary of Changes

  • .babelrc webpack.json - adding react-dom file to the resolve which will prevent require issue in webpack

Test Plan

running the debugger.html and check the log for exceptions

Here's the Debugger's Testing doc
https://docs.google.com/document/d/1oBMRxV8A2ag2t22YsQOxTdEv0mXKzIg0tggJjRkU1S0/edit#.
Feel free to improve it!

Copy link
Contributor

@jasonLaster jasonLaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mind explaining what was happening here?

@amitmtrn
Copy link
Contributor Author

there is an issue with react and webpack where the require import the react library which cause React = ReactDOM. it will also effect future versions of react and react-dom.
the fix I did is to require the file directly while skipping the package.json of react-dom.

@jasonLaster jasonLaster merged commit ed0e2a3 into firefox-devtools:master Jan 17, 2017
@jasonLaster
Copy link
Contributor

jasonLaster commented Jan 17, 2017

Thanks @amitmtrn, I really appreciate the help. this was a very old frustrating bug!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants