This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Add a search bottom bar and move the search modifiers to the bottom bar. #2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonLaster
reviewed
Feb 23, 2017
|
|
||
| return dom.div( | ||
| { className: "search-bar" }, | ||
| this.renderSearchField(), |
There was a problem hiding this comment.
hmm, how aboutt searchInput
There was a problem hiding this comment.
I considered that but we have this.searchInput that I didn't want to confuse it with.
src/components/Editor/SearchBar.css
Outdated
| display: flex; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .search-bar .search-modifiers button { | ||
| .search-mod-bar .search-modifiers button { |
There was a problem hiding this comment.
hmm, perhaps we want to call it search-bottom-bar
There was a problem hiding this comment.
I had done that first and renamed it because I didn't want to type as much 馃槅
wldcordeiro
force-pushed
the
search-bottom-bar
branch
from
16027d9
to
ea8a395
Compare
jasonLaster
approved these changes
Feb 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Issue: #2078 and #2000
Summary of Changes
Test Plan
Screenshots/Videos
@jasonLaster I know we want the modifiers on the right side and I'll get that once function search is moved too. 馃槃