Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

[Scopes] expanded properties are not updated while stepping #2509

Merged
merged 11 commits into from Apr 5, 2017
Merged

[Scopes] expanded properties are not updated while stepping #2509

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
96fc2a6
Fix expanded properties are not updated while stepping
arthur801031 Mar 31, 2017
47f48cd
Revert yarn.lock
arthur801031 Mar 31, 2017
1e61143
Move code logic to ObjectInspector
arthur801031 Mar 31, 2017
a6ef1b4
Made a few corrections
arthur801031 Mar 31, 2017
b1ed6d1
Retrieve property values
arthur801031 Apr 1, 2017
79bb50b
Remove code from previous commit
arthur801031 Apr 1, 2017
ac94d3a
Revert to previous implementation
arthur801031 Apr 4, 2017
1e41c11
Revert yarn.lock
arthur801031 Apr 4, 2017
ed50775
Merge branch 'master' into properties
jasonLaster Apr 4, 2017
7932d8f
Move code logic to object-inspector and add a unit test
arthur801031 Apr 5, 2017
8557ef9
Simplify code
arthur801031 Apr 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/utils/object-inspector.js
View file
Open in desktop
Expand Up @@ -181,7 +181,19 @@ function getChildren(
// node would be a new instance every render.
const key = item.path;
if (actors && actors[key]) {
return actors[key];
const properties = item.contents.value.preview.ownProperties;
let thisActor = actors[key];
for (let pKey in properties) {
if (properties.hasOwnProperty(pKey)) {
const cacheObject = thisActor.filter(a => a.name == pKey)[0];
const cacheObjectIndex = thisActor.findIndex(a => a.name == pKey);
// Assign new values to the cache actor if it becomes stale
if (cacheObject && getValue(cacheObject) != properties[pKey].value) {
thisActor[cacheObjectIndex].contents = properties[pKey];
}
}
}
return thisActor;
Copy link
Contributor

@bomsy bomsy Mar 31, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! If we move this change to the ObjectInspector.js here instead.
Then we can do this.props.setActors(actors); after, which will set the cached actor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion! I thought using this.props.setActors(actors); in render would cause an error, but I was wrong! Thank you! 😊

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding actors[key] = thisActor; above this line should update actorCache

Copy link
Contributor

@bomsy bomsy Apr 3, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also , the actors[key] only goes stale across the ObjectInspector component loads (i.e during stepping), therefore across internal component renders we should still be fine doing return actors[key]if it exists, due to performance reasons.

}

if (isBucket(item)) {
Expand Down