Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

add immutable js lib to list of libraries #3588

Merged
merged 1 commit into from Aug 7, 2017

Conversation

yaelballa
Copy link

@yaelballa yaelballa commented Aug 7, 2017

Associated Issue: #2980

This is similar to #2868. Just another framework.

Summary of Changes

  • added Immutable JS logo (converted from png, didn't find matching logo for immutable js)
  • added recognition of Immutable js file name.

Test Plan

  • Open my app with immutable js
  • Add breakpoint on immutable js code call and drill down
  • View call stack panel - immutable js is identified

@yaelballa
Copy link
Author

#goodnessSquad

@jasonLaster
Copy link
Contributor

@yaelballa mind sharing a screenshot?

@yaelballa yaelballa mentioned this pull request Aug 7, 2017
18 tasks
@codecov
Copy link

codecov bot commented Aug 7, 2017

Codecov Report

Merging #3588 into master will decrease coverage by 1.39%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3588     +/-   ##
=========================================
- Coverage   54.41%   53.02%   -1.4%     
=========================================
  Files         119      119             
  Lines        4662     4664      +2     
  Branches      962      963      +1     
=========================================
- Hits         2537     2473     -64     
- Misses       2125     2191     +66
Impacted Files Coverage Δ
assets/images/Svg.js 84.61% <ø> (ø) ⬆️
src/utils/frame.js 83.08% <75%> (-0.25%) ⬇️
src/components/shared/SearchInput.js 8.33% <0%> (-84.26%) ⬇️
src/components/shared/Modal.js 10.52% <0%> (-77.71%) ⬇️
src/utils/result-list.js 0% <0%> (-36.59%) ⬇️
src/components/SymbolModal.js 30.23% <0%> (-12.85%) ⬇️
src/actions/ast.js 78.57% <0%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4069f0f...fb08756. Read the comment docs.

@yaelballa
Copy link
Author

immutable js in call stack
immutable js in call stack
when not selected
immutable js in call stack when not selected

Copy link
Contributor

@jasonLaster jasonLaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Love It!

@jasonLaster jasonLaster merged commit 3b3772c into firefox-devtools:master Aug 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants