Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

[Sources] Reveal in tree opens the left sidebar #5885

Merged
merged 1 commit into from Apr 7, 2018

Conversation

marcobeltempo
Copy link
Contributor

Fixes Issue: #5869

Summary of Changes

When selecting Reveal in tree from the context menu, it now checks:

  • if the left panel is collapsed
    • opens if it is

Test Plan

  • Select Reveal in tree with the left panel closed to make sure it opened
  • Select Reveal in tree with the left panel opened to make sure it didn't collapse
  • With the context menu opened, enter Shift + Alt + r will also open the left panel

Screenshots/Videos

debugger_html_issue5869

Copy link
Contributor

@jasonLaster jasonLaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This looks great. I’ll test it soon

@jasonLaster
Copy link
Contributor

Thanks for the help!

By the way, you should join our slack https://devtools-html-slack.herokuapp.com/ and say hi!

Copy link
Contributor

@AnshulMalik AnshulMalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@jasonLaster jasonLaster changed the title Fixes #5869 - Opens the left sidebar when selecting to "Reveal in tree" [Sources] Reveal in tree opens the left sidebar Apr 7, 2018
@AnshulMalik AnshulMalik merged commit 03618a6 into firefox-devtools:master Apr 7, 2018
jasonLaster pushed a commit that referenced this pull request Apr 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants