Skip to content
This repository has been archived by the owner. It is now read-only.

[Sources] Reveal in tree opens the left sidebar #5885

Merged
merged 1 commit into from Apr 7, 2018

Conversation

@marcobeltempo
Copy link
Contributor

@marcobeltempo marcobeltempo commented Apr 7, 2018

Fixes Issue: #5869

Summary of Changes

When selecting Reveal in tree from the context menu, it now checks:

  • if the left panel is collapsed
    • opens if it is

Test Plan

  • Select Reveal in tree with the left panel closed to make sure it opened
  • Select Reveal in tree with the left panel opened to make sure it didn't collapse
  • With the context menu opened, enter Shift + Alt + r will also open the left panel

Screenshots/Videos

debugger_html_issue5869

…ree" from context menu
Copy link
Contributor

@jasonLaster jasonLaster left a comment

Nice! This looks great. I’ll test it soon

@jasonLaster
Copy link
Contributor

@jasonLaster jasonLaster commented Apr 7, 2018

Thanks for the help!

By the way, you should join our slack https://devtools-html-slack.herokuapp.com/ and say hi!

Copy link
Member

@AnshulMalik AnshulMalik left a comment

This is great!

@jasonLaster jasonLaster changed the title Fixes #5869 - Opens the left sidebar when selecting to "Reveal in tree" [Sources] Reveal in tree opens the left sidebar Apr 7, 2018
@AnshulMalik AnshulMalik merged commit 03618a6 into firefox-devtools:master Apr 7, 2018
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
jasonLaster added a commit that referenced this pull request Apr 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants