Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

Update babel-eslint and bump launchpad to 0.0.114 #889

Closed
wants to merge 1 commit into from

Conversation

nchevobbe
Copy link
Member

@nchevobbe nchevobbe commented Jan 10, 2018

@nchevobbe
Copy link
Member Author

CI is failing because of devtools-license-check complaining about pako being MIT and Zlib.
pako is not requested directly and is probably a dependency of babel-eslint.

I'm unsure what should be done here.

@nchevobbe
Copy link
Member Author

Zlib license seems pretty good for us. Should we add it to devtools-license-check valid licences ? @captainbrosset do you have an opinion on this ?

Copy link
Contributor

@codehag codehag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question -- im not too sure how to review this. pbro and @jasonLaster probably have a good idea though. I don't know if we need to clear this with any legal agents... would be good to know!

@captainbrosset
Copy link
Contributor

If this is a devDependency, then we should be fine, no need to check anything, we're not shipping or embedding code anywhere. And looking at the mentioned issue, I guess this is or should be a devDependency.

It it's not, then that means we're distributing Pako with our software and should therefore make sure its license is a compatible one.
It looks like it is, so feel free to open a PR against the license-checker and ask Tom for a quick review.

@nchevobbe
Copy link
Member Author

So it is a direct dependency at the moment, in the devtools-launchpad package (which we publish).
@jasonLaster is there any reason to keep it as a dependency and not a dev one ?
Also, can't we have this dependency as a devDependency on the debugger instead ?

@jasonLaster
Copy link
Contributor

we can make it a devDependency.

The debugger now has devDependencies for the eslint plugins

@nchevobbe
Copy link
Member Author

the dependency was added in debugger and now everything is fine (after releasing a new version of devtools-licenes-check to support Zlib).
Let's put that aside for now

@nchevobbe nchevobbe closed this Jan 11, 2018
@nchevobbe nchevobbe deleted the launchpad-babel-eslint branch January 25, 2018 16:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yarn lint-js throws
4 participants