Skip to content

Commit

Permalink
Review comment: Change remaining UI still using the name 'publish'
Browse files Browse the repository at this point in the history
  • Loading branch information
julienw committed Nov 17, 2020
1 parent cfef0f5 commit a876008
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/components/app/ListOfPublishedProfiles.js
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ export class ListOfPublishedProfiles extends PureComponent<Props, State> {

if (!profileDataList.length) {
return (
<p className="photon-body-30">No profile has been published yet!</p>
<p className="photon-body-30">No profile has been uploaded yet!</p>
);
}

Expand Down
6 changes: 3 additions & 3 deletions src/components/app/MenuButtons/Publish.js
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ class MenuButtonsPublishImpl extends React.PureComponent<PublishProps> {
>
<div className="menuButtonsPublishUploadTop">
<div className="menuButtonsPublishUploadTitle">
Publishing profile…
Uploading profile…
</div>
<div className="menuButtonsPublishUploadPercentage">
{uploadProgressString}
Expand Down Expand Up @@ -240,7 +240,7 @@ class MenuButtonsPublishImpl extends React.PureComponent<PublishProps> {
_renderErrorPanel() {
const { error, resetUploadState } = this.props;
let message: string =
'There was an unknown error when trying to publish the profile.';
'There was an unknown error when trying to upload the profile.';
if (
error &&
typeof error === 'object' &&
Expand All @@ -259,7 +259,7 @@ class MenuButtonsPublishImpl extends React.PureComponent<PublishProps> {
data-testid="MenuButtonsPublish-container"
>
<div className="photon-message-bar photon-message-bar-error">
Uh oh, something went wrong when publishing the profile.
Uh oh, something went wrong when uploading the profile.
<button
className="photon-button photon-button-micro photon-message-bar-action-button"
type="button"
Expand Down
2 changes: 1 addition & 1 deletion src/test/components/UploadedRecordingsHome.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ describe('UploadedRecordingsHome', () => {

it('matches a snapshot when there is no published profiles', async () => {
const { container, findByText } = setup();
await findByText(/No profile has been published/);
await findByText(/No profile has been uploaded/);
expect(container.firstChild).toMatchSnapshot();
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ exports[`ListOfPublishedProfiles renders a generic message when there is no prof
<p
class="photon-body-30"
>
No profile has been published yet!
No profile has been uploaded yet!
</p>
</div>
`;
Expand Down
2 changes: 1 addition & 1 deletion src/test/components/__snapshots__/MenuButtons.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,7 @@ exports[`app/MenuButtons <Publish> matches the snapshot for an error 1`] = `
<div
class="photon-message-bar photon-message-bar-error"
>
Uh oh, something went wrong when publishing the profile.
Uh oh, something went wrong when uploading the profile.
<button
class="photon-button photon-button-micro photon-message-bar-action-button"
type="button"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ exports[`UploadedRecordingsHome matches a snapshot when there is no published pr
<p
class="photon-body-30"
>
No profile has been published yet!
No profile has been uploaded yet!
</p>
</main>
`;

0 comments on commit a876008

Please sign in to comment.