Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slow marker canvas painting even when only a small range is displayed #955

Closed
mstange opened this issue Apr 21, 2018 · 2 comments
Closed

Slow marker canvas painting even when only a small range is displayed #955

mstange opened this issue Apr 21, 2018 · 2 comments
Labels
markers Anything to do with marker data structures, marker chart, or the marker table perf Issues where the profiler itself is slow.

Comments

@mstange
Copy link
Contributor

mstange commented Apr 21, 2018 •
edited

Steps to reproduce:

  1. Open https://perfht.ml/2HhuMD1
  2. Move your mouse over one of the DOMEvent markers in the marker chart tab.

There's a noticeable delay before the tooltip appears. It looks like we're busy painting markers during that time. It seems like we're painting all markers in the thread instead of just the ones in the displayed range.
@mstange mstange added the perf Issues where the profiler itself is slow. label Apr 21, 2018
@julienw
Copy link
Contributor

julienw commented Apr 21, 2018

Yeah, actually @gregtatum started to fix this in #865.

@julienw julienw added the markers Anything to do with marker data structures, marker chart, or the marker table label Apr 21, 2018
@julienw
Copy link
Contributor

julienw commented Aug 31, 2018

The scenario outlined above seems to work fine now. Maybe fixed by #1134

@julienw julienw closed this as completed Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
markers Anything to do with marker data structures, marker chart, or the marker table perf Issues where the profiler itself is slow.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julienw @mstange