Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd copy marker name #2277
Closed
Add copy marker name #2277
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Oct 10, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #2277 +/- ##
==========================================
- Coverage 86.11% 86.09% -0.03%
==========================================
Files 203 203
Lines 14824 14831 +7
Branches 3713 3720 +7
==========================================
+ Hits 12766 12769 +3
- Misses 1886 1889 +3
- Partials 172 173 +1
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
Thanks for your work, we'll look at it shortly! |
This comment has been minimized.
This comment has been minimized.
(I started the review but got interrupted, sorry about that. I still hope to do it before the end of the week) |
This comment has been minimized.
This comment has been minimized.
@julienw no worries, there is no rush :) |
This comment has been minimized.
This comment has been minimized.
As I said in the issue, this problem has been fixed in #1915 some time ago already. Sorry about this mistake :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
miggs125 commentedOct 10, 2019
•
edited
Fixes #1251
I added the Copy Marker Name option for markers that have the
name
property.