Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy marker name #2277

Closed

Conversation

@miggs125
Copy link

miggs125 commented Oct 10, 2019

Fixes #1251
I added the Copy Marker Name option for markers that have the name property.

Screenshot_20191009_211918

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #2277 into master will decrease coverage by 0.02%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2277      +/-   ##
==========================================
- Coverage   86.11%   86.09%   -0.03%     
==========================================
  Files         203      203              
  Lines       14824    14831       +7     
  Branches     3713     3720       +7     
==========================================
+ Hits        12766    12769       +3     
- Misses       1886     1889       +3     
- Partials      172      173       +1
Impacted Files Coverage Δ
src/components/shared/MarkerContextMenu.js 41.46% <42.85%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efe2f99...40013ce. Read the comment docs.

@miggs125 miggs125 changed the title pull from upstream Add copy marker name Oct 10, 2019
@julienw julienw self-requested a review Oct 14, 2019
@julienw

This comment has been minimized.

Copy link
Contributor

julienw commented Oct 14, 2019

Thanks for your work, we'll look at it shortly!

@julienw

This comment has been minimized.

Copy link
Contributor

julienw commented Oct 17, 2019

(I started the review but got interrupted, sorry about that. I still hope to do it before the end of the week)

@miggs125

This comment has been minimized.

Copy link
Author

miggs125 commented Oct 18, 2019

@julienw no worries, there is no rush :)

@julienw

This comment has been minimized.

Copy link
Contributor

julienw commented Oct 21, 2019

As I said in the issue, this problem has been fixed in #1915 some time ago already. Sorry about this mistake :(

@julienw julienw closed this Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.