Show add-on name on flame graph tooltip

[NisaSource]

This is issue #2790. I'm waiting for somebody to review and advise me as I see performance issue.
I have added library (add-on name) to tooltip but it isn't good from performance view because when I hover on tooltip with my mouse it is calling redux action multiple times instead of one time.

[canova]

Thanks for the work!

So in this PR, we are using selectedNodeSelectors but that will not help us for this case because we are not "selecting" a node. We are actually "hovering" a node. So we should find a different solution for this. For example this is the function call we do to get the display information from the callNodeIndex. So, we should ideally change this function and return an additional lib in this so we can use it here.

profiler/src/components/tooltip/CallNode.js

Line 194 in b4beaae

displayData = callTree.getDisplayData(callNodeIndex);

This is the function we call there:

profiler/src/profile-logic/call-tree.js

Line 213 in c4f68f4

getDisplayData(callNodeIndex: IndexIntoCallNodeTable): CallNodeDisplayData {

You can also take a look at the getLib selector to have an idea on how we get this string.

I hope this and the comments below will give you some idea on how to fix this. Let me know if you have questions!

[codecov]

Codecov Report

Merging #2921 into main will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2921      +/-   ##
==========================================
+ Coverage   87.55%   87.58%   +0.03%     
==========================================
  Files         235      235              
  Lines       18802    18803       +1     
  Branches     4784     4784              
==========================================
+ Hits        16462    16469       +7     
+ Misses       2163     2158       -5     
+ Partials      177      176       -1     

Impacted Files	Coverage Δ
src/components/tooltip/CallNode.js	87.05% <100.00%> (+7.29%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faa830c...acee7b6. Read the comment docs.

[julienw]

Thanks for doing this, this is close to what was suggested the issue. But I think the suggestion wasn't the best, so I've left another suggestion which I think will give a better result.
Please try it and tell me how this looks!

[julienw]

Please request review again by clicking on the small arrows in the Reviewers section at the top right of this page. Thanks!

[julienw]

This looks good to me!
I added a commit that adds a test to test this. This doesn't test the case of an addon but the case of using a library, but this should exercize the same code. I did it myself because this was a bit technical and I didn't want to bother you with that.

Hey @canova, would you please have a look at this added commit? Thanks!

[julienw]

😊

[canova]

Thanks for adding a test Julien, looks good to me!
Also thanks for working on this PR @NisaSource!

[julienw]

FYI I squashed all your commits into one, so that it was easier to rebase on top of the latest code, but still keep your authorship information for your work.

Now waiting for all tests before landing!

[NisaSource]

Thank you @julienw and @canova :)