Fix screenshot stacking with respect to permalink overlay #3073
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3073 +/- ##
=======================================
Coverage 88.13% 88.13%
=======================================
Files 240 240
Lines 19100 19106 +6
Branches 4880 4885 +5
=======================================
+ Hits 16833 16839 +6
Misses 2100 2100
Partials 167 167
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thanks a lot, this looks good!
I noticed we have another problem around context menus:
Can you please look if increasing the z-index in ContextMenu.css (currently it's 4) will fix this? Also if this work, please change the comment there adding a mention about screenshots. If this doesn't work please ignore this and we can file another issue about that. (but I'm confident this will work).
Thanks again for your patience!
(Note: this is the profile I've been using here: full link)
| z-index: 10; | ||
| z-index: 5; |
There was a problem hiding this comment.
May I ask why this change? I mean, I'm not opposed :-) but this doesn't seem useful.
There was a problem hiding this comment.
This change was just meant to put z-indexes in order. The element below this one has an index of 4, so I just ordered them that way, so that we don’t use arbitrary numbers.
However, I’m not sure if it was intentionally given a large number. If so, we can definitely change it back to 10 :)
There was a problem hiding this comment.
yeah I think this is good, more "ordered". Especially if we sue "10" this should be explained better than just an arbitrary number, so in this case "5" is just as good. Thanks :-)
Projects that are a bit more in order than our project for z-index do have a clear plan about them. They also keep some "space" so that it's possible to add elements between the stacks without changing everything. We're not there yet!
This pull request changes the way screenshot-hover is rendered so that it has same parent stacking context as permalink, and therefore enables the stacking to be ordered by their z-index.
Fixes #1274
┆Issue is synchronized with this Jira Task