Fixes an edge case when the tooltip wouldn't move closer to the mouse cursor in some situations #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cursor in some situations This would happen in this situation: * The user hovers an element, whose tooltip is too big for the available space: the tooltip would align with the window's left edge. * Then the user hovers another element whose tooltip would have space to go either at the right or left of the cursor. In that case we reuse the previous position, so that the tooltip stays stable. But if the previous position was the window-edge, then the tooltip would stay at that location and could be far from the mouse cursor.
julienw
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3663 +/- ##
==========================================
+ Coverage 88.77% 88.91% +0.13%
==========================================
Files 259 258 -1
Lines 21746 21547 -199
Branches 5564 5509 -55
==========================================
- Hits 19305 19158 -147
+ Misses 2262 2214 -48
+ Partials 179 175 -4
Continue to review full report at Codecov.
|
…-to-another-position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would happen in this situation:
space: the tooltip would align with the window's left edge.
go either at the right or left of the cursor. In that case we reuse the
previous position, so that the tooltip stays stable.
But if the previous position was the window-edge, then the tooltip
would stay at that location and could be far from the mouse cursor.
You can test with these links by reducing the window width a lot, or using the devtools docked at the right and increasing the devtools width to reduce the window width:
production / deploy preview
Before:
After:
