Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint-plugin-testing-library 5.11.1 → 6.0.1 (major) #132

Closed

Conversation

depfu[bot]
Copy link

@depfu depfu bot commented Sep 2, 2023

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ eslint-plugin-testing-library (5.11.1 → 6.0.1) · Repo

Release Notes

6.0.1

6.0.1 (2023-08-24)

Bug Fixes

  • no-await-sync-events: stop reporting user-event by default (#803) (88246fc)

6.0.0

6.0.0 (2023-08-12)

You can follow the migration guide to v6.

BREAKING CHANGES

  • await-async-query: await-async-query is now called await-async-queries
  • no-await-sync-events: no-await-sync-events is now enabled by default in the DOM, Angular & React configs
  • no-await-sync-query: no-await-sync-query is now called no-await-sync-queries
  • no-debugging-utils: no-debugging-utils now enables all debug methods in all configs by default
  • no-node-access: no-node-access is now enabled by default in the DOM config
  • await-fire-event: await-fire-event is now called await-async-event
  • no-global-regexp-flag-in-query: no-global-regexp-flag-in-query is now enabled by default in all configs
  • no-manual-cleanup: no-manual-cleanup is now enabled by default in the React & Vue configs
  • no-render-in-setup: no-render-in-setup is now called no-render-in-lifecycle
  • prefer-wait-for: prefer-wait-for is now removed

Bug Fixes

  • await-async-event: pluralize to await-async-events (#670) (7238f76)
  • await-async-events: improve fixer (#675) (9d5554c)

Features

  • await-async-event: add basic fixer (#656) (b4b5394)
  • await-async-query: rename to await-async-queries (#665) (c1803df)
  • await-fire-event: rename to await-async-event + add support for user-event (#652) (b4ce9bb)
  • no-await-sync-events: add to DOM, Angular & React configs by default (#667) (afce5ea)
  • no-await-sync-query: rename to no-await-sync-queries (#666) (7ed3da8)
  • no-debugging-utils: enable all debug methods in all configs by default (#663) (e394ce0)
  • no-debugging-utils: warn instead of error in all configs (#662) (8063f8f)
  • no-global-regexp-flag-in-query: add to all configs by default (#660) (c76a7bf)
  • no-manual-cleanup: add to React & Vue configs by default (#659) (8f6ebf5)
  • no-node-access: add to DOM config by default (#661) (8dfe155)
  • no-render-in-setup: rename to no-render-in-lifecycle (#649) (9acba43)
  • prefer-wait-for: remove rule (#648) (20f23ad)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 11 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the dependencies Pull requests that update a dependency file label Sep 2, 2023
@depfu depfu bot requested review from canova and julienw September 2, 2023 11:50
@netlify
Copy link

netlify bot commented Sep 2, 2023

Deploy Preview for firefox-devtools-react-contextmenu ready!

Name Link
🔨 Latest commit 062860e
🔍 Latest deploy log https://app.netlify.com/sites/firefox-devtools-react-contextmenu/deploys/64f3218278f4c10008b6c3de
😎 Deploy Preview https://deploy-preview-132--firefox-devtools-react-contextmenu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julienw
Copy link

julienw commented Sep 4, 2023

The linting issue is invalid, see testing-library/eslint-plugin-testing-library#800
Let's see if this is resolved soon, otherwise we can disable the new behavior in config.

@julienw julienw closed this Sep 4, 2023
@depfu depfu bot deleted the depfu/update/yarn/eslint-plugin-testing-library-6.0.1 branch September 4, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant