Dont show Shippingcost link when product is configurable and only consists from virtual products

[Flyingmana]

If you have a configurable, but only add virtual products as children, there is still the sippingcost link.

The reason I think is this code:
https://github.com/firegento/firegento-magesetup/blob/2.2.1/src/app/code/community/FireGento/MageSetup/Block/Catalog/Product/Price.php#L203

Source: IRC

[riconeitzel]

we're happy to see a PR here :-)

[sreichel]

This should work ... can someone confirm before a create a PR?

public function isShowShippingLink()
{
    $productTypeId = $this->getProduct()->getTypeId();
    $ignoreTypeIds = array('virtual', 'downloadable');

    // --- fix
    if ($productTypeId === 'configurable') {
        $childProducts = Mage::getModel('catalog/product_type_configurable')->getUsedProducts(null, $this->getProduct());

        foreach ($childProducts as $child) {
            if (!in_array($child->getTypeId(), $ignoreTypeIds)) {
                return true;
            }
        }
        return false;
    }
    // ---

    if (in_array($productTypeId, $ignoreTypeIds)) {
        return false;
    }

    return true;
}

[sprankhub]

Thanks. I fear to be the bad guy again :D but I am not sure if we should include that. It looks good and should work, but the getUsedProducts method has a significant performance footprint. If the block is cached properly, this may be okay. But I think only few people use virtual products (at least in combination with configurable products), so that it may be better to ignore that issue...

[Schrank]

I agree here with @sprankhub. We can fix this by implementing our own ResourceModel to get this info directly from database without getUsedProducts AND cache it :-)

[riconeitzel]

@Schrank any code available yet? @sprankhub you perhaps?!

[sprankhub]

Unfortunately not, sorry...