-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add firehydrant_teams and firehydrant_team data source #121
Conversation
351957c
to
3126442
Compare
CreateTeam(ctx context.Context, req CreateTeamRequest) (*TeamResponse, error) | ||
UpdateTeam(ctx context.Context, id string, req UpdateTeamRequest) (*TeamResponse, error) | ||
DeleteTeam(ctx context.Context, id string) error | ||
Teams() TeamsClient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for moving this into a proper interface. 👏
3126442
to
930d555
Compare
Hi @bobbytables - thanks for the review! Any chance you or someone from your team could take another look? Thanks! |
@bobbytables Any help here? Would be great to get this in, or something similar. It's blocking our ability to utilize firehydrant via terraform. Is there anything we can do to help? |
930d555
to
22c48d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks quite solid. And to be frank upgrading go version should be relatively safe, but I would still like to see it on a different PR just in case there are any regressions :)
go.mod
Outdated
@@ -1,22 +1,64 @@ | |||
module github.com/firehydrant/terraform-provider-firehydrant | |||
|
|||
go 1.16 | |||
go 1.18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@splittingred is it necessary to bump the go version for this PR?
Would it be possible to open a separate PR with just the version change?
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elg0nz yep, I can. This provider is currently broken on main as:
# github.com/zclconf/go-cty/cty/set
note: module requires Go 1.18
# github.com/hashicorp/terraform-plugin-go/internal/logging
note: module requires Go 1.18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,44 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice docs
@splittingred if you don't mind rebasing, this looks good to me for merge and release. |
22c48d0
to
14b025d
Compare
14b025d
to
1c9ec9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last one hopefully!
1c9ec9e
to
2b891e6
Compare
Description
Adds two new data sources, as per #108
firehydrant_teams
- withquery
as a filterfirehydrant_team
- withid
argumentAlso aligns teams interfaces with sub-struct approach of other areas.
Also, had to update the go.mod to 1.18 (the test suite was already on 1.18(!)), as a lot of the deps were no long er 1.16-compatible.
Testing plan
Related links
PR readiness