Add warning and fallback when auto intensity is 0 #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occassionally the auto adjust doesn't find enough memory and the intensity is detected too low and aligned to 0 with the compute units. This patch fixes this situation by issuing a warning with a suggestion to set environment vars and then ignoring the alignment to 0 Per several issues: Principally: fireice-uk#81 Related: fireice-uk#490 fireice-uk#472
|
I will check this soon, maybe I will push some change on top of you PR to remove the link to all issue. I will also check first if it is better that no config is generated in the case where the intensity is zero. |
- if the intensity is zero than do not suggest a config - remove the links to old issues
psychocrypt
force-pushed
the
fix_zero_intensity
branch
from
af4238f
to
14f6063
Compare
|
@fireice-uk Could you please check this PR, I pushed a commit on top and therefore will give the review into your hands. |
fireice-uk
approved these changes
Jan 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occassionally the auto adjust doesn't find enough memory and the
intensity is detected too low and aligned to 0 with the compute units.
This patch fixes this situation by issuing a warning with a suggestion
to set environment vars and then ignoring the alignment to 0
Per several issues:
Principally:
#81
Related:
#490
#472