Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed invalid memory access of MMIO port addresses #1317

Merged
merged 1 commit into from Dec 9, 2022
Merged

Conversation

nandor
Copy link
Contributor

@nandor nandor commented Dec 6, 2022

UART no longer keeps a reference. Fixed the typo causing the invalid access.

Related PRs / Issues

UI / API Impact

Verilog / AGFI Compatibility

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

UART no longer keeps a reference. Fixed the typo causing the invalid access.
@nandor nandor added the changelog:omit Do not include this PR in the changelog label Dec 6, 2022
@davidbiancolin
Copy link
Contributor

@abejgonzalez This need ci:fpga-deploy

@davidbiancolin
Copy link
Contributor

@nandor, thanks. Could you add a bounds check in simif somewhere? That could help catch future problems in lieu of better testing.

@nandor
Copy link
Contributor Author

nandor commented Dec 6, 2022

I've created #1318 to follow up on this.

@davidbiancolin davidbiancolin merged commit 1f3a76b into main Dec 9, 2022
@davidbiancolin davidbiancolin deleted the mmio-fix branch December 9, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:omit Do not include this PR in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants