Fix Vitis CI

[abejgonzalez]

This fixes the Vitis CI by adding a -ldl to the linker for all systems (should be safe for v18/20 Ubuntu systems). As part of this PR, I also regenerated an xclbin (@ 140MHz). Instead of placing it on the server, I instead download it from the internet (I created a publicly accessible bucket under the AWS CI account) so anyone could potentially build their own bitstream, add it to the S3 bucket, and just change the link to it. In the future, this can use a URI (once we add URI support back into the manager).

Related PRs / Issues

UI / API Impact

Verilog / AGFI Compatibility

Contributor Checklist

• Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
• Did you add Scaladoc/docstring/doxygen to every public function/method?
• Did you add at least one test demonstrating the PR?
• Did you delete any extraneous prints/debugging code?
• Did you state the UI / API impact?
• Did you specify the Verilog / AGFI compatibility impact?

• If applicable, did you regenerate and publicly share default AGFIs?

• If applicable, did you apply the ci:fpga-deploy label?

• If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

• Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
• Did you mark the proper release milestone?
• Did you check whether all relevant Contributor checkboxes have been checked?

[davidbiancolin]

In the distant past we used to use s3 to host FPGA images (in the fpga-zynq days). We could do the same with HWDB collateral.

[abejgonzalez]

In the distant past we used to use s3 to host FPGA images (in the fpga-zynq days). We could do the same with HWDB collateral.

For users that don't have an AWS account (and maybe don't want one), would they be able to download S3 objects? My impression is that you are required to have an account to access anything in an S3 bucket.

[t14916]

My impression is that you are required to have an account to access anything in an S3 bucket.

If the bucket is public, then you can access it without an account afaik. Should be able to just access it through the URI.

[abejgonzalez]

@t14916 This should now be good to re-review. The Vitis test failed with a -22 (see https://github.com/firesim/firesim/actions/runs/3803123263/jobs/6469259435#step:4:4676) but that's because Berkeley had to restart the machine hosting the FPGA for misc. OS updates. I've gone ahead and re-setup the CI machine to work properly and validated that it can run our FireSim tests. Happy to re-run the CI if you want to triple-check that this CI works (the Vitis CI previously passed before the restart).

[abejgonzalez]

@t14916 @davidbiancolin This PR is ready for review.

[t14916]

LGTM, but just as an FYI your XRT shell PR here: #1385 is being merged into this branch so you might wanna either merge that first or merge it into main.

[abejgonzalez]

LGTM, but just as an FYI your XRT shell PR here: #1385 is being merged into this branch so you might wanna either merge that first or merge it into main.

Yup. I did that on purpose so that the diff wasn't horrible since I was working on that PR on the same branch as this. GitHub is smart enough to change the base branch once this PR goes in.