Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCS and Verilator DPI switchover #1348

Merged
merged 1 commit into from Jan 4, 2023
Merged

VCS and Verilator DPI switchover #1348

merged 1 commit into from Jan 4, 2023

Conversation

nandor
Copy link
Contributor

@nandor nandor commented Dec 25, 2022

This PR unifies the VCS and Verilator toplevels. After this change, the simulation is nested under the top-level and synchronisation between the driver and the simulations is identical across both environments.

Unfortunately, huge variance in performance is noticeable, caused by the --output-split flag of verilator. With the change, the splits are selected such that a regression is noticeable, however performance can be regained by tweaking the option.

Related PRs / Issues

UI / API Impact

Verilog / AGFI Compatibility

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@nandor nandor added the changelog:changed Put PR title in 'Changed' section of changelog label Dec 25, 2022
@nandor nandor force-pushed the verilator-vcs-dpi branch 2 times, most recently from f7ac6ba to aae751f Compare December 26, 2022 09:51
Copy link
Contributor

@sifive-benjamin-morse sifive-benjamin-morse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some const that could be added, but they are from legacy code. Looks good to me.

@nandor nandor merged commit ea85e93 into main Jan 4, 2023
@nandor nandor deleted the verilator-vcs-dpi branch January 4, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:changed Put PR title in 'Changed' section of changelog ci:fpga-deploy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants