Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes needed to support Scala 2.13 #1388

Merged
merged 1 commit into from Jan 18, 2023
Merged

Conversation

sifive-benjamin-morse
Copy link
Contributor

DRAFT

Fixes needed to support Scala 2.13
Mostly need .toSeq on mutable Seqs
A few import resolution, was pickup wrong Utils.
Fixed Seq problem returned in tuple

Related PRs / Issues

UI / API Impact

Verilog / AGFI Compatibility

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

Fixes needed to support Scala 2.13
Mostly need .toSeq on mutable Seqs
A few import resolution, was pickup wrong Utils.
Fixed Seq problem returned in tuple
Copy link
Contributor

@davidbiancolin davidbiancolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes themselves look good.

@sifive-benjamin-morse sifive-benjamin-morse marked this pull request as ready for review January 18, 2023 19:10
@sifive-benjamin-morse sifive-benjamin-morse merged commit 72bba18 into main Jan 18, 2023
@sifive-benjamin-morse sifive-benjamin-morse deleted the bmorse/scala-2.13 branch January 18, 2023 19:11
@sifive-benjamin-morse sifive-benjamin-morse added the changelog:fixed Put PR title in 'Fixed' section of changelog label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed Put PR title in 'Fixed' section of changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants