New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dedup. CI Requirements #1445
Dedup. CI Requirements #1445
Conversation
8b7184e
to
d3b0976
Compare
d3b0976
to
f6867a9
Compare
This should also fix the errors with https://github.com/firesim/firesim/actions/workflows/firesim-cleanup.yml |
Something went wrong in the workflow monitor for CI run 4318413117. Verify CI instances are terminated properly. Must be checked before submitting the PR. Exception Message:
Traceback Message:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#1443 pointed out that there is an extra
requirement.txt
that is used in CI that can probably be deduped. This PR tries deduping this file by using conda in the CI. This requires that the conda requirements file is split in 2 (one file for FireSim specific reqs, and one file for shared CI/FireSim deps). This is also unpinning some dependencies now that we haveconda-lock
.Related PRs / Issues
UI / API Impact
Verilog / AGFI Compatibility
Contributor Checklist
changelog:<topic>
label?ci:fpga-deploy
label?Please Backport
label?Reviewer Checklist (only modified by reviewer)
Note: to run CI on PRs from forks, comment
@Mergifyio copy main
and manage the change from the new PR.changelog:<topic>
label?