Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedup. CI Requirements #1445

Merged
merged 7 commits into from Mar 3, 2023
Merged

Dedup. CI Requirements #1445

merged 7 commits into from Mar 3, 2023

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Feb 28, 2023

#1443 pointed out that there is an extra requirement.txt that is used in CI that can probably be deduped. This PR tries deduping this file by using conda in the CI. This requires that the conda requirements file is split in 2 (one file for FireSim specific reqs, and one file for shared CI/FireSim deps). This is also unpinning some dependencies now that we have conda-lock.

Related PRs / Issues

UI / API Impact

Verilog / AGFI Compatibility

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@abejgonzalez abejgonzalez changed the title Dedup ci reqs Dedup. CI Requirements Feb 28, 2023
@abejgonzalez abejgonzalez requested a review from t14916 March 2, 2023 21:27
@abejgonzalez
Copy link
Contributor Author

This should also fix the errors with https://github.com/firesim/firesim/actions/workflows/firesim-cleanup.yml

@abejgonzalez
Copy link
Contributor Author

Something went wrong in the workflow monitor for CI run 4318413117. Verify CI instances are terminated properly. Must be checked before submitting the PR.

Exception Message:

Unable to retrieve count of GitHub Actions Runners
Full Response Below:
<Response [502]>

Traceback Message:

Traceback (most recent call last):
  File "/home/centos/firesim/.github/scripts/./workflow-monitor.py", line 69, in main
    platform_lib.terminate_instances(ci_env['PERSONAL_ACCESS_TOKEN'], ci_env['GITHUB_RUN_ID'])
  File "/home/centos/firesim/.github/scripts/platform_lib.py", line 141, in terminate_instances
    self.change_workflow_instance_states(gh_token, workflow_tag, 'terminate')
  File "/home/centos/firesim/.github/scripts/platform_lib.py", line 264, in change_workflow_instance_states
    self.deregister_runners(gh_token, f"aws-{workflow_tag}")
  File "/home/centos/firesim/.github/scripts/github_common.py", line 51, in deregister_runners
    runners = get_runners(gh_token)
  File "/home/centos/firesim/.github/scripts/github_common.py", line 23, in get_runners
    raise Exception(f"Unable to retrieve count of GitHub Actions Runners\nFull Response Below:\n{r}")
Exception: Unable to retrieve count of GitHub Actions Runners
Full Response Below:
<Response [502]>

@abejgonzalez
Copy link
Contributor Author

This PR should be good to go. GH actions went down in the middle of the PR but the same steps worked in prior commits:

image

Copy link
Contributor

@t14916 t14916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abejgonzalez abejgonzalez merged commit 4d43808 into main Mar 3, 2023
@abejgonzalez abejgonzalez deleted the dedup-ci-reqs branch March 3, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants