Revert to UInt64 for offsetConst in SerialBridge #1463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1398 broke FireSim Rocket supernode builds. You can see here that the
mem_host_offset
is 64b wide: https://github.com/firesim/firesim/pull/1398/files#diff-098225fbdae21ed16399652d570908e98dc7918a7e98ccf118c689e41c3f0c3bL19. However, here you can see that the constructor generates aUInt32
instead of originally a 64b int: https://github.com/firesim/firesim/pull/1398/files#diff-ba1d4635003f304c25f2a454cd7882c077b1ac291d846afd39dbc65003f35f65R103. This PR fixes this issue.Related PRs / Issues
UI / API Impact
Verilog / AGFI Compatibility
Contributor Checklist
changelog:<topic>
label?ci:fpga-deploy
label?Please Backport
label?Reviewer Checklist (only modified by reviewer)
Note: to run CI on PRs from forks, comment
@Mergifyio copy main
and manage the change from the new PR.changelog:<topic>
label?