Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to UInt64 for offsetConst in SerialBridge #1463

Merged
merged 1 commit into from Mar 9, 2023

Conversation

abejgonzalez
Copy link
Contributor

PR #1398 broke FireSim Rocket supernode builds. You can see here that the mem_host_offset is 64b wide: https://github.com/firesim/firesim/pull/1398/files#diff-098225fbdae21ed16399652d570908e98dc7918a7e98ccf118c689e41c3f0c3bL19. However, here you can see that the constructor generates a UInt32 instead of originally a 64b int: https://github.com/firesim/firesim/pull/1398/files#diff-ba1d4635003f304c25f2a454cd7882c077b1ac291d846afd39dbc65003f35f65R103. This PR fixes this issue.

Related PRs / Issues

UI / API Impact

Verilog / AGFI Compatibility

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@abejgonzalez abejgonzalez requested a review from nandor March 9, 2023 02:11
@abejgonzalez abejgonzalez self-assigned this Mar 9, 2023
@abejgonzalez abejgonzalez added the bug Something isn't working label Mar 9, 2023
@abejgonzalez abejgonzalez requested a review from sagark March 9, 2023 17:26
Copy link
Member

@sagark sagark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abejgonzalez abejgonzalez merged commit 9375903 into main Mar 9, 2023
@abejgonzalez abejgonzalez deleted the fix-serialbridge-supernoderocketconfig branch March 9, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants