Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump conda-reqs | Bump Chipyard #1470

Merged
merged 6 commits into from Mar 16, 2023
Merged

Bump conda-reqs | Bump Chipyard #1470

merged 6 commits into from Mar 16, 2023

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Mar 14, 2023

Chipyard bumped to a newer version of the toolchain (FireMarshal bump that also removed the need for e2fsprogs in the conda env) that needs to be updated in the conda requirements. I also pinned s3fs to =0.4.6 to avoid issues where aiobotocore (a prereq of s3fs) would be updated too far and break pytests.

Additionally, we plan on bumping to a newer version of Verilator that removes the C++ top-level in favor of Rocket Chips TestDriver.v as the top level. This is compatible with current Verilator makefiles. This is broken in FireSim so I will delay this to the following release.

Related PRs / Issues

UI / API Impact

Verilog / AGFI Compatibility

No changes to Verilog so no AGFIs were regenerated.

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@abejgonzalez
Copy link
Contributor Author

Side Note: This commit was accidentally added to main (and was subsequently reverted). I updated the main branch rules to make it read-only (no pushes).

@abejgonzalez abejgonzalez merged commit f3bf507 into main Mar 16, 2023
@abejgonzalez abejgonzalez deleted the bump-cy branch March 16, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants