Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FREQUENCY as a prereq in Vitis builds #1472

Merged
merged 2 commits into from Mar 22, 2023
Merged

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Mar 17, 2023

If you build a bitstream with a specific FREQUENCY given in the config_build_recipe.yaml, you will generate a .xo file using that frequency. However, if you update the recipe frequency without updating the build tuple, you will not regenerate the .xo file, hence keeping the same frequency until you do a make clean in the cl_* dir. This adds a new make function that allows you to add the FREQUENCY variable as a prereq., allowing it to regenerate the .xo file if changed.

Related PRs / Issues

UI / API Impact

Verilog / AGFI Compatibility

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@abejgonzalez abejgonzalez enabled auto-merge (squash) March 18, 2023 21:49
@abejgonzalez abejgonzalez self-assigned this Mar 18, 2023
@abejgonzalez abejgonzalez merged commit 4a41f47 into main Mar 22, 2023
@abejgonzalez abejgonzalez deleted the vitis-use-freq-as-prereq branch March 22, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants