Add fallback when email's not in token (#1686)

Fixes #1684
firezone · Jun 23, 2023 · 47417d3 · 47417d3 · vercel · Jun 23, 2023
1 parent ccae7ba
commit 47417d3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/apps/fz_http/lib/fz_http_web/user_from_auth.ex b/apps/fz_http/lib/fz_http_web/user_from_auth.ex
@@ -36,6 +36,11 @@ defmodule FzHttpWeb.UserFromAuth do
     end
   end
 
+  # Fallback
+  def find_or_create(_provider_id, _params) do
+    {:error, "unknown provider or email not found in params"}
+  end
+
   defp maybe_create_user(idp_field, provider_id, email) do
     if Auth.auto_create_users?(idp_field, provider_id) do
       Users.create_user(:unprivileged, %{email: email})

diff --git a/apps/fz_http/test/fz_http_web/user_from_auth_test.exs b/apps/fz_http/test/fz_http_web/user_from_auth_test.exs
@@ -86,4 +86,9 @@ defmodule FzHttpWeb.UserFromAuthTest do
       assert Users.fetch_user_by_email(email) == {:error, :not_found}
     end
   end
+
+  describe "find_or_create/2 with missing email" do
+    assert {:error, "unknown provider or email not found in params"} =
+             UserFromAuth.find_or_create("dummy", %{"sub" => "1234"})
+  end
 end