Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fallback when email claim's not in ID token from OIDC provider #1686

Merged
merged 4 commits into from
Jun 23, 2023
Merged

Add fallback when email claim's not in ID token from OIDC provider #1686

merged 4 commits into from
Jun 23, 2023

Conversation

jamilbk
Copy link
Member

@jamilbk jamilbk commented Jun 23, 2023

Fixes #1684

@jamilbk jamilbk requested a review from AndrewDryga June 23, 2023 14:20
@jamilbk jamilbk self-assigned this Jun 23, 2023
@vercel
Copy link

vercel bot commented Jun 23, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Jun 23, 2023 6:44pm

@github-actions github-actions bot added the kind/bug Something isn't working label Jun 23, 2023
@jamilbk jamilbk mentioned this pull request Jun 23, 2023
Closed
@coveralls
Copy link

coveralls commented Jun 23, 2023 •
edited

Pull Request Test Coverage Report for Build ae99cc658527b405afdd18925164968f88bf313e-PR-1686

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 70.679%
Totals Coverage Status
Change from base Build ccae7bad646f89356c22844666e389ce1fcbfd53: 0.01%
Covered Lines: 1967
Relevant Lines: 2783
💛 - Coveralls

@jamilbk jamilbk enabled auto-merge (squash) June 23, 2023 14:34
@jamilbk jamilbk changed the title Add fallback when email's not in token Add fallback when email claim's not in ID token from OIDC provider Jun 23, 2023
@jamilbk jamilbk merged commit 47417d3 into master Jun 23, 2023
4 checks passed
@jamilbk jamilbk deleted the fix/add-fallback-for-email-not-found-cases branch June 23, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewDryga AndrewDryga AndrewDryga approved these changes

Assignees

@jamilbk jamilbk

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error 500 on Callback stage of OIDC-based SSO flow on Azure
3 participants
@jamilbk @coveralls @AndrewDryga