Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firezone GUI does not react to close the key generation window #1353

Closed
kinseii opened this issue Jan 21, 2023 · 11 comments · Fixed by #1384
Closed

Firezone GUI does not react to close the key generation window #1353

kinseii opened this issue Jan 21, 2023 · 11 comments · Fixed by #1384

Comments

@kinseii
Copy link

kinseii commented Jan 21, 2023

OS: Windows 10
Browser: Google Chrome Version 109.0.5414.75 (Official Build) (64-bit) - Latest
Firezone: 0.7.4 dockerized

There is a little bug - after the generation of the WireGuard key in the GUI Firezone, the generation window does not close. GUI does not react to close the window.

@jamilbk
Copy link
Member

jamilbk commented Jan 21, 2023

Thanks for the report @kinseii.

  • Does the modal close if you press the escape key or click outside the modal?
  • Could you share any browser console logs that appear at the time of click that may be relevant?

That'll help debug the issue. We do have this covered in tests (#1356) that helps ensure the modal is dismissed, but there could be another issue with your browser or session.

@jamilbk jamilbk closed this as completed Jan 21, 2023
@kinseii
Copy link
Author

kinseii commented Jan 21, 2023

@jamilbk
Please reopen the Issue. I have a clarification - when you open the Add Device window, you can close it with a cross or with the Esc key. But when you press Download WireGuard configuration the window stops closing, you have to close the browser tab.

@jamilbk
Copy link
Member

jamilbk commented Jan 21, 2023

Thanks for the clarification.

@jamilbk jamilbk reopened this Jan 21, 2023
@jamilbk
Copy link
Member

jamilbk commented Jan 21, 2023

If you could post relevant browser console logs and firezone container logs at the time of occurrence that would help us diagnose the issue.

@kinseii
Copy link
Author

kinseii commented Jan 21, 2023

I opened the browser console, but it's blank. I tried reloading the page, but it also stayed blank.

image

Nothing appears in the server logs when you click on the cross, there are only login logs

data-firezone-1  | 19:45:41.493 request_id=FzxqkxlnnnMccFgAAAyS [info] GET /
data-firezone-1  | 19:45:41.495 request_id=FzxqkxlnnnMccFgAAAyS remote_ip=20.25.hidd.en [info] Sent 302 in 2ms
data-firezone-1  | 19:45:41.597 request_id=Fzxqkx-WXdqAI08AAAyi [info] GET /user_devices
data-firezone-1  | 19:45:41.604 request_id=Fzxqkx-WXdqAI08AAAyi remote_ip=20.25.hidd.en [info] Sent 200 in 6ms
data-firezone-1  | 19:45:42.186 [info] CONNECTED TO Phoenix.LiveView.Socket in 48µs
data-firezone-1  |   Transport: :websocket
data-firezone-1  |   Serializer: Phoenix.Socket.V2.JSONSerializer
data-firezone-1  |   Parameters: %{"_csrf_token" => "GGUBI1wvFR9jGDE********************************ReV", "_live_referer" => "undefined", "_mounts" => "0", "_track_static" => %{"0" => "https://vpn-users-hidd.en/dist/unprivileged-f5863ffa9667a9***********************.css?vsn=d", "1" => "https://vpn-users.hidd.en/dist/unprivileged-407b7514465bcf******************b.js?vsn=d"}, "vsn" => "2.0.0"}
data-firezone-1  | 19:45:42.472 [info] CONNECTED TO FzHttpWeb.UserSocket in 169µs
data-firezone-1  |   Transport: :websocket
data-firezone-1  |   Serializer: Phoenix.Socket.V2.JSONSerializer
data-firezone-1  |   Parameters: %{"token" => "SFMyNTY.g2gDbQAA***********i1lYjdhLTQyZj*********************************NuEjH8K7_VsxfUdMqj32y3ehaI6_eTiw", "vsn" => "2.0.0"}
data-firezone-1  | 19:45:42.571 [info] JOINED notification:session in 757µs
data-firezone-1  |   Parameters: %{"token" => "SFMyNTY.g2gDbQ**********1lYjdhLT************************3VhQFiAAFRgA.Y2qHNZZ-9iDvglxWIeGJl7MTpbunXBMCe422cf-4cOE"}

@kinseii
Copy link
Author

kinseii commented Jan 21, 2023

@jamilbk
Please give me the instructions and I will make the necessary report. Thank you!

AndrewDryga added a commit that referenced this issue Jan 23, 2023
Refs #1353 

I was looking for a `refute_el` helper to check for `.modal.is-active`
*not* being on the page, but that would take time to write 😅

This checks to ensure the URL is updated, which should cause the
`@live_action` to change, the view to be patched, and the modal to be
dismissed, but isn't the most straightforward way to make sure the modal
isn't visible.

We've hit this problem twice before (am not successful this morning
finding the relevant issues):

* If the WebSocket is flapping, the event may not register. But usually
the browser will refresh if this is the case (we have a red indicator in
the upper-right to indicate if the websocket is not connected, i.e. the
views aren't "live")
* A CSS bug caused the click event to target the wrong LiveView PID (the
modal's parent I believe), which ended up crashing it because it didn't
have the "close" event handler defined. I believe the escape keydown
still closed the view though in that case.

This feels more like the first issue, given the acceptance test is
passing.

Co-authored-by: Andrew Dryga <andrew@dryga.com>
@jamilbk
Copy link
Member

jamilbk commented Jan 24, 2023

Hi @kinseii -- sorry but I'm having trouble reproducing. Tested with Firefox and Chrome on macOS. Is it possible you have a browser extension loaded that's conflicting somehow?

Screen.Recording.2023-01-24.at.1.56.54.PM.mov

@jamilbk jamilbk closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2023
@kinseii
Copy link
Author

kinseii commented Jan 26, 2023

@jamilbk Hi, have you clicked on Download WireGuard configuration?

@kinseii
Copy link
Author

kinseii commented Jan 26, 2023

2023-01-26.12-59-02.mov

@kinseii
Copy link
Author

kinseii commented Jan 26, 2023

None of the plugins are enabled.

@jamilbk
Copy link
Member

jamilbk commented Jan 26, 2023

Thanks! I was able to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants