-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firezone GUI does not react to close the key generation window #1353
Comments
Thanks for the report @kinseii.
That'll help debug the issue. We do have this covered in tests (#1356) that helps ensure the modal is dismissed, but there could be another issue with your browser or session. |
@jamilbk |
Thanks for the clarification. |
If you could post relevant browser console logs and firezone container logs at the time of occurrence that would help us diagnose the issue. |
I opened the browser console, but it's blank. I tried reloading the page, but it also stayed blank. Nothing appears in the server logs when you click on the cross, there are only login logs
|
@jamilbk |
Refs #1353 I was looking for a `refute_el` helper to check for `.modal.is-active` *not* being on the page, but that would take time to write 😅 This checks to ensure the URL is updated, which should cause the `@live_action` to change, the view to be patched, and the modal to be dismissed, but isn't the most straightforward way to make sure the modal isn't visible. We've hit this problem twice before (am not successful this morning finding the relevant issues): * If the WebSocket is flapping, the event may not register. But usually the browser will refresh if this is the case (we have a red indicator in the upper-right to indicate if the websocket is not connected, i.e. the views aren't "live") * A CSS bug caused the click event to target the wrong LiveView PID (the modal's parent I believe), which ended up crashing it because it didn't have the "close" event handler defined. I believe the escape keydown still closed the view though in that case. This feels more like the first issue, given the acceptance test is passing. Co-authored-by: Andrew Dryga <andrew@dryga.com>
Hi @kinseii -- sorry but I'm having trouble reproducing. Tested with Firefox and Chrome on macOS. Is it possible you have a browser extension loaded that's conflicting somehow? Screen.Recording.2023-01-24.at.1.56.54.PM.mov |
@jamilbk Hi, have you clicked on |
2023-01-26.12-59-02.mov |
None of the plugins are enabled. |
Thanks! I was able to reproduce. |
OS: Windows 10
Browser: Google Chrome Version 109.0.5414.75 (Official Build) (64-bit) - Latest
Firezone: 0.7.4 dockerized
There is a little bug - after the generation of the WireGuard key in the GUI Firezone, the generation window does not close. GUI does not react to close the window.
The text was updated successfully, but these errors were encountered: