Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Containers don't appear to be writeable on macOS 12 / iOS 15 #3565

Closed
jamilbk opened this issue Feb 5, 2024 · 1 comment · Fixed by #4133
Closed

Group Containers don't appear to be writeable on macOS 12 / iOS 15 #3565

jamilbk opened this issue Feb 5, 2024 · 1 comment · Fixed by #4133
Assignees
Labels
area/apple_client Issues related to the Apple client business_value/low Required by < 10% of our customer base kind/bug Something isn't working
Milestone

Comments

@jamilbk
Copy link
Member

jamilbk commented Feb 5, 2024

As I was browsing through the clients list today, I noticed @roop's iPhone running iOS 15 exhibits the same behavior that @AndrewDryga is experiencing on macOS 12.

What's happening is the firezone-id file is not able to be written to the Group Container store, causing a random one to be used each time the client authenticates. This causes duplicate clients to appear in the portal:

Screenshot 2024-02-05 at 6 11 49 AM

Fixing this will probably also fix the Tunnel Keychain popup @AndrewDryga is experiencing.

@jamilbk
Copy link
Member Author

jamilbk commented Feb 5, 2024

@roop I suspect fixing this for your iOS 15 will also fix it for macOS 12. It seems like the container store is not getting set up properly for writes on these two OSes?

@jamilbk jamilbk added kind/bug Something isn't working area/apple_client Issues related to the Apple client labels Feb 5, 2024
@jamilbk jamilbk added this to the 1.0 GA milestone Feb 5, 2024
@jamilbk jamilbk added the business_value/low Required by < 10% of our customer base label Feb 5, 2024
@jamilbk jamilbk changed the title Group Containers don't appear to work on macOS 12 / iOS 15 Group Containers don't appear to be writeable on macOS 12 / iOS 15 Feb 5, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 8, 2024
This PR adds some log messages to help debug why the firezone-id might
not get written to / read from disk (related to issue #3565).
@jamilbk jamilbk assigned jamilbk and unassigned roop Mar 20, 2024
github-merge-queue bot pushed a commit that referenced this issue Mar 27, 2024
Tried to organize this PR into commits so that it's a bit easier to
review.

1. Involves simplifying the logic in Adapter.swift so that us mortals
can maintain it confidently:
- The `.stoppingTunnel`, `.stoppedTunnelTemporarily`, and
`.stoppingTunnelTemporarily` states have been removed.
- I also removed the `self.` prefix from local vars when it's not
necessary to use it, to be more consistent.
- `onTunnelReady` and `getSystemDefaultResolvers` has been removed, and
`onUpdateRoutes` wired up, along with cleanup necessary to support that.
2. Involves adding the `reconnect` and `set_dns` stubs in the FFI and
fixing the log filter so that we can log them (see #4182 )
3. Involves getting the path update handler working well on macOS using
`SystemConfiguration` to read DNS servers.
4. Involves getting the path update handler working well on iOS by
employing careful trickery to prevent path update cycles by detecting if
`path.gateways` has changed, and avoid setting new DNS if it hasn't.

Refs #4028 
Fixes #4297
Fixes #3565 
Fixes #3429 
Fixes #4175 
Fixes #4176 
Fixes #4309

---------

Signed-off-by: Jamil <jamilbk@users.noreply.github.com>
Co-authored-by: Reactor Scram <ReactorScram@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apple_client Issues related to the Apple client business_value/low Required by < 10% of our customer base kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants