Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid settings crashes app #4297

Closed
jamilbk opened this issue Mar 25, 2024 · 0 comments · Fixed by #4133
Closed

Invalid settings crashes app #4297

jamilbk opened this issue Mar 25, 2024 · 0 comments · Fixed by #4133
Labels
area/apple_client Issues related to the Apple client kind/bug Something isn't working

Comments

@jamilbk
Copy link
Member

jamilbk commented Mar 25, 2024 •
edited

Entering a non-URL in settings attempting to launch the sign in flow causes a crash.
@jamilbk jamilbk added area/apple_client Issues related to the Apple client kind/bug Something isn't working labels Mar 25, 2024
@jamilbk jamilbk mentioned this issue Mar 25, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 27, 2024
@jamilbk @ReactorScram
feat(apple): Handle network changes reliably on macOS and iOS (#4133)
ab598ef 
Tried to organize this PR into commits so that it's a bit easier to
review.

1. Involves simplifying the logic in Adapter.swift so that us mortals
can maintain it confidently:
- The `.stoppingTunnel`, `.stoppedTunnelTemporarily`, and
`.stoppingTunnelTemporarily` states have been removed.
- I also removed the `self.` prefix from local vars when it's not
necessary to use it, to be more consistent.
- `onTunnelReady` and `getSystemDefaultResolvers` has been removed, and
`onUpdateRoutes` wired up, along with cleanup necessary to support that.
2. Involves adding the `reconnect` and `set_dns` stubs in the FFI and
fixing the log filter so that we can log them (see #4182 )
3. Involves getting the path update handler working well on macOS using
`SystemConfiguration` to read DNS servers.
4. Involves getting the path update handler working well on iOS by
employing careful trickery to prevent path update cycles by detecting if
`path.gateways` has changed, and avoid setting new DNS if it hasn't.

Refs #4028 
Fixes #4297
Fixes #3565 
Fixes #3429 
Fixes #4175 
Fixes #4176 
Fixes #4309

---------

Signed-off-by: Jamil <jamilbk@users.noreply.github.com>
Co-authored-by: Reactor Scram <ReactorScram@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/apple_client Issues related to the Apple client kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(apple): Handle network changes reliably on macOS and iOS firezone/firezone
1 participant
@jamilbk