Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show Settings window on App Start #3961

Closed
jamilbk opened this issue Mar 5, 2024 · 9 comments · Fixed by #4013
Closed

Don't show Settings window on App Start #3961

jamilbk opened this issue Mar 5, 2024 · 9 comments · Fixed by #4013
Assignees
Labels
area/tauri_client The Windows and Linux Tauri GUI clients kind/feedback Issue created as a direct result of customer feedback kind/UX Changes related specifically to overall user experience and product quality
Milestone

Comments

@jamilbk
Copy link
Member

jamilbk commented Mar 5, 2024

No description provided.

@jamilbk jamilbk added kind/UX Changes related specifically to overall user experience and product quality kind/feedback Issue created as a direct result of customer feedback area/tauri_client The Windows and Linux Tauri GUI clients labels Mar 5, 2024
@ReactorScram
Copy link
Collaborator

Agreed. But there is a problem that Windows hides our tray icon by default, and a tray icon may not be an obvious enough launch notification on the first time.

So we can try forcing the tray icon to show, at least while Firezone is signed out: https://superuser.com/questions/1753209/

And we could use the generation of the device ID (firezone-id) as a cue to do a little "first-time install" thing, maybe have a notification saying, "Firezone is in the tray, sign in to access resources"

At the most extreme we could show a notification every time Firezone starts signed-out saying "Sign in to Firezone"

@jamilbk
Copy link
Member Author

jamilbk commented Mar 5, 2024

I like the firezone-id trick. Could we use that to show a simple Welcome to Firezone view, with a little screenshot / arrow pointing to the lower right?

E.g. "Welcome to Firezone. Use the taskbar icon to sign in."

I can whip up a graphic / view

@jamilbk
Copy link
Member Author

jamilbk commented Mar 5, 2024

Ah but I guess on Linux it'd be in the upper-right most likely. Instead of the arrow we could just show a zoomed in screenshot of the icon running in the Taskbar / Menubar

@ReactorScram
Copy link
Collaborator

Yeah that could work. On Windows XP the notifications used to point right at the tray icon and for some reason they removed that, so you can't tell where stuff is coming from as easily
image

@jamilbk
Copy link
Member Author

jamilbk commented Mar 5, 2024

Oh, does Tauri support UI notifications? Maybe we could show that on first launch instead?

@jamilbk
Copy link
Member Author

jamilbk commented Mar 5, 2024

Either or, I don't feel strongly. The macOS / iOS / Android apps shows a welcome screen with the "Grant VPN permission" button.

On Tauri it could be similar, minus the "Grant" buton

@ReactorScram
Copy link
Collaborator

Yeah not sure if it's Tauri or some other dep but we have notifications for updates, re-auth and signed-in events:
image

@ReactorScram ReactorScram added this to the 1.0 GA milestone Mar 5, 2024
@ReactorScram
Copy link
Collaborator

Agreed on standup to add a third window "Welcome" which can't be explicitly shown but is shown after first install and then not shown once the user dismisses it (for some bikeshed-able definition of "dismiss")

I'm not sure if we can somehow detect an "Install ID" for this case:

  • User installs, runs, dismisses Welcome, un-installs, installs, runs, window should appear
  • User installs, runs, dismisses Welcome, updates, runs, window should not appear

@jamilbk
Copy link
Member Author

jamilbk commented Mar 6, 2024

User installs, runs, dismisses Welcome, un-installs, installs, runs, window should appear

Maybe it can be assumed the user already knows where to find Firezone in this case.

I think it's mostly to help users who have never seen Firezone at all

github-merge-queue bot pushed a commit that referenced this issue Mar 19, 2024
Closes #3961 

No tests yet, might be tricky to test since it's all I/O. 
I cued it off the device ID being generated, so it will have a minor
merge conflict with #3920

```[tasklist]
### Before merging
- [ ] UI polish, or disable the welcome screen temporarily
```

<img width="664" alt="image"
src="https://github.com/firezone/firezone/assets/13400041/d5def59c-b075-4135-91e5-85f9f9212fa5">

---------

Co-authored-by: Jamil Bou Kheir <jamilbk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tauri_client The Windows and Linux Tauri GUI clients kind/feedback Issue created as a direct result of customer feedback kind/UX Changes related specifically to overall user experience and product quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants