Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gui-client): Tauri welcome screen #4013

Merged
merged 9 commits into from
Mar 19, 2024
Merged

Conversation

ReactorScram
Copy link
Collaborator

@ReactorScram ReactorScram commented Mar 6, 2024

Closes #3961

No tests yet, might be tricky to test since it's all I/O.
I cued it off the device ID being generated, so it will have a minor merge conflict with #3920

Before merging

Edit tasklist title
Beta Give feedback Tasklist Before merging, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. UI polish, or disable the welcome screen temporarily
    Options
image

@ReactorScram ReactorScram self-assigned this Mar 6, 2024
Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2024 10:35pm

Copy link

github-actions bot commented Mar 6, 2024

Terraform Cloud Plan Output

Plan: 9 to add, 8 to change, 9 to destroy.

Terraform Cloud Plan

@ReactorScram ReactorScram marked this pull request as ready for review March 6, 2024 23:33
Copy link

github-actions bot commented Mar 6, 2024

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 227.3 MiB (+0%) 228.7 MiB (+0%) 218 (-15%)
direct-tcp-server2client 230.9 MiB (-1%) 232.5 MiB (-1%) 173 (-31%)
relayed-tcp-client2server 147.6 MiB (+3%) 148.2 MiB (+2%) 162 (+49%)
relayed-tcp-server2client 154.1 MiB (-2%) 154.5 MiB (-2%) 170 (-13%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 50.0 MiB (-0%) 0.21ms (+392%) 0.00% (NaN%)
direct-udp-server2client 50.0 MiB (+0%) 0.02ms (+32%) 0.00% (NaN%)
relayed-udp-client2server 50.0 MiB (-0%) 0.22ms (+127%) 0.00% (NaN%)
relayed-udp-server2client 50.0 MiB (+0%) 0.06ms (-6%) 0.00% (NaN%)

@jamilbk
Copy link
Member

jamilbk commented Mar 7, 2024

LGTM, OK if I push a couple UI commits into this PR at some point?

@ReactorScram
Copy link
Collaborator Author

@jamilbk Yep go for it

@jamilbk jamilbk assigned jamilbk and unassigned ReactorScram Mar 12, 2024
@jamilbk
Copy link
Member

jamilbk commented Mar 12, 2024

Still need to get to this one.

@jamilbk jamilbk marked this pull request as draft March 12, 2024 17:14
@ReactorScram
Copy link
Collaborator Author

I could reference the About and Settings windows and just make something rough for the time being

@jamilbk
Copy link
Member

jamilbk commented Mar 18, 2024

@ReactorScram I think this is ready for you take over. I need help wiring up the Sign in button to close the welcome window and launch the sign in flow. Could you finish that part of this PR? I think it's ready for merge after that.

Screenshot 2024-03-17 at 9 01 19 PM

@jamilbk jamilbk assigned ReactorScram and unassigned jamilbk Mar 18, 2024
@ReactorScram
Copy link
Collaborator Author

ReactorScram commented Mar 18, 2024

Got it hooked up and it works fine in Windows and Debian.

It sends the same command as clicking "Sign In" in the tray menu, so both of them will hide the Welcome window and open the browser for auth. If the window's already hidden it just opens the browser, since hide is idempotent.

image

@ReactorScram ReactorScram marked this pull request as ready for review March 18, 2024 22:40
@ReactorScram ReactorScram added this pull request to the merge queue Mar 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 19, 2024
@ReactorScram ReactorScram added this pull request to the merge queue Mar 19, 2024
Merged via the queue into main with commit adea43e Mar 19, 2024
137 checks passed
@ReactorScram ReactorScram deleted the feat/tauri-welcome-screen branch March 19, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't show Settings window on App Start
2 participants