Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows app shortcut icon is not HiDPI #3999

Closed
jamilbk opened this issue Mar 6, 2024 · 6 comments · Fixed by #4304
Closed

Windows app shortcut icon is not HiDPI #3999

jamilbk opened this issue Mar 6, 2024 · 6 comments · Fixed by #4304
Assignees
@jamilbk
Labels
area/windows_client Issues related to the Windows client

Comments

@jamilbk
Copy link
Member

jamilbk commented Mar 6, 2024

No description provided.

@jamilbk jamilbk added the area/windows_client Issues related to the Windows client label Mar 6, 2024
@bmanifold
Copy link
Collaborator

Here's what it looks like on my screen. My resolution is set to: 3840 x 2160
firezone-logo-pixelated

@jamilbk jamilbk changed the title Windows taskbar icon is not HiDPI Windows app shortcut icon is not HiDPI Mar 6, 2024
@ReactorScram ReactorScram mentioned this issue Mar 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 7, 2024
@ReactorScram
fix: let Tauri know about hiDPI icons (#4039)
21d6e4f 
Untested guess, refs #3999

Looks like we generated a 2x PNG but didn't tell Tauri about it, maybe
it'll know what to do if it's added to tauri.conf.json.
@jamilbk
Copy link
Member Author

jamilbk commented Mar 8, 2024 •
edited
Loading

@bmanifold Think a fix was merged for this, may want to double-check if you're able?

@bmanifold
Copy link
Collaborator

Unfortunately, the icon is still pixelated on my machine.

@ReactorScram ReactorScram self-assigned this Mar 8, 2024
@ReactorScram ReactorScram added this to the 2.0-beta milestone Mar 8, 2024
@ReactorScram
Copy link
Collaborator

Ah I wasn't subscribed to this issue.

That's too bad. I marked it with a late milestone since it's visual and we can probably put it off.

@bmanifold
Copy link
Collaborator

Yeah, it's not definitely not a priority, just a small thing I noticed. Let me know if/when you need me to test something again.

@jamilbk jamilbk assigned jamilbk and unassigned ReactorScram Mar 20, 2024
@jamilbk jamilbk modified the milestones: 2.0-beta, 1.0 GA Mar 20, 2024
@jamilbk jamilbk mentioned this issue Mar 25, 2024
Merged
@jamilbk jamilbk removed this from the 1.0 GA milestone Mar 25, 2024
github-merge-queue bot pushed a commit that referenced this issue Mar 27, 2024
@jamilbk
chore(gui-client): Remove unused Tauri app icons (#4304)
13c5b18 
Not sure if this will fix #3999 but the ~~colors for the existing icon
are wrong, so we need to fix them anyway.~~

Removes unused Tauri app icons.

Refs #3999
@bmanifold
Copy link
Collaborator

Just wanted to report back. The last time I installed the windows client (which was Apr 3, 2024) I noticed that the icon on my desktop was a hi-res icon like the others 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamilbk jamilbk

Labels
area/windows_client Issues related to the Windows client
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(gui-client): Remove unused Tauri app icons firezone/firezone
3 participants
@jamilbk @bmanifold @ReactorScram