Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: let Tauri know about hiDPI icons #4039

Merged
merged 2 commits into from
Mar 7, 2024
Merged

fix: let Tauri know about hiDPI icons #4039

merged 2 commits into from
Mar 7, 2024

Conversation

ReactorScram
Copy link
Collaborator

@ReactorScram ReactorScram commented Mar 7, 2024

Untested guess, refs #3999

Looks like we generated a 2x PNG but didn't tell Tauri about it, maybe it'll know what to do if it's added to tauri.conf.json.

@ReactorScram ReactorScram self-assigned this Mar 7, 2024
Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2024 10:56pm

Copy link

github-actions bot commented Mar 7, 2024

Terraform Cloud Plan Output

Plan: 8 to add, 7 to change, 2 to destroy.

Terraform Cloud Plan

Copy link

github-actions bot commented Mar 7, 2024

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 64.5 MiB (-1%) 65.0 MiB (-1%) 41 (0%)
direct-tcp-server2client 53.2 MiB (-1%) 53.4 MiB (-1%) 32 (-14%)
relayed-tcp-client2server 30.4 MiB (+4%) 31.9 MiB (+5%) 116 (-58%)
relayed-tcp-server2client 28.8 MiB (-6%) 30.5 MiB (-5%) 117 (+95%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 50.0 MiB (+0%) 0.18ms (-52%) 0.00% (NaN%)
direct-udp-server2client 50.0 MiB (+0%) 0.19ms (-20%) 0.53% (+26897%)
relayed-udp-client2server 50.0 MiB (+0%) 0.30ms (+9%) 20.41% (-4%)
relayed-udp-server2client 50.0 MiB (-0%) 1.05ms (+215%) 20.77% (-0%)

@ReactorScram ReactorScram marked this pull request as ready for review March 7, 2024 20:37
Copy link
Member

@jamilbk jamilbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe mark the ref as "refs #3999 " so we can close it later if it's fixed.

@ReactorScram ReactorScram added this pull request to the merge queue Mar 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 7, 2024
@ReactorScram ReactorScram added this pull request to the merge queue Mar 7, 2024
Merged via the queue into main with commit 21d6e4f Mar 7, 2024
64 checks passed
@ReactorScram ReactorScram deleted the fix/hidpi-icons branch March 7, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants