Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(apple): CI/CD check for forbidden syscalls like fstat #4393

Closed
ReactorScram opened this issue Mar 29, 2024 · 1 comment
Closed

ci(apple): CI/CD check for forbidden syscalls like fstat #4393

ReactorScram opened this issue Mar 29, 2024 · 1 comment
Assignees
@jamilbk
Labels
area/apple_client Issues related to the Apple client area/ci Changes to the CI pipeline / Github Actions needs triage Issues opened by the public or need further labeling
Milestone
1.0 GA

Comments

@ReactorScram
Copy link
Collaborator

https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api

https://github.com/Wooder/ios_17_required_reason_api_scanner/tree/main
@ReactorScram ReactorScram added area/ci Changes to the CI pipeline / Github Actions area/apple_client Issues related to the Apple client needs triage Issues opened by the public or need further labeling labels Mar 29, 2024
@ReactorScram ReactorScram added this to the 2.0-beta milestone Mar 29, 2024
@jamilbk jamilbk mentioned this issue Mar 29, 2024
Merged
@jamilbk jamilbk modified the milestones: 2.0-beta, 1.0 GA Mar 29, 2024
github-merge-queue bot pushed a commit that referenced this issue Mar 29, 2024
@jamilbk @ReactorScram
chore(connlib): Remove atomicwrites and tokio::fs from apple compile …
c30138b 
…path (#4395)

Fixes #4377 


Manually verified by running `nm` on the resulting binaries. I'll open
another PR to handle #4393

---------

Signed-off-by: Jamil <jamilbk@users.noreply.github.com>
Co-authored-by: Reactor Scram <ReactorScram@users.noreply.github.com>
@jamilbk
Copy link
Member

jamilbk commented Mar 30, 2024

I managed to prune out all of our dependencies on fstat, but rustc still links against libSystem at the end of the day, which pulls in fstat and stat, so this CI check won't be that useful.

#4400 should eliminate the need for this CI check.

@jamilbk jamilbk closed this as not planned Won't fix, can't repro, duplicate, stale Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamilbk jamilbk

Labels
area/apple_client Issues related to the Apple client area/ci Changes to the CI pipeline / Github Actions needs triage Issues opened by the public or need further labeling
Projects
None yet
Milestone
1.0 GA
Development

No branches or pull requests
2 participants
@jamilbk @ReactorScram