Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apple): Add PrivacyManifest #4400

Merged
merged 2 commits into from
Mar 30, 2024
Merged

chore(apple): Add PrivacyManifest #4400

merged 2 commits into from
Mar 30, 2024

Conversation

jamilbk
Copy link
Member

@jamilbk jamilbk commented Mar 30, 2024

It seems that even after getting rid of all of our direct dependencies on fstat, rust compiles our library against libSystem anyway (libc) and so these calls are impossible to get rid of.

Instead, we declare a privacy manifest.

fixes #4377

Copy link

vercel bot commented Mar 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview Mar 30, 2024 6:04am

Copy link

github-actions bot commented Mar 30, 2024

Terraform Cloud Plan Output

Plan: 15 to add, 14 to change, 15 to destroy.

Terraform Cloud Plan

Copy link

github-actions bot commented Mar 30, 2024

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 224.9 MiB (-2%) 227.2 MiB (-1%) 245 (+6%)
direct-tcp-server2client 222.0 MiB (-3%) 223.6 MiB (-3%) 359 (+5%)
relayed-tcp-client2server 152.4 MiB (+4%) 153.1 MiB (+4%) 174 (-9%)
relayed-tcp-server2client 149.6 MiB (-3%) 150.0 MiB (-3%) 183 (+12%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 50.0 MiB (-0%) 0.31ms (+725%) 0.00% (NaN%)
direct-udp-server2client 50.0 MiB (-0%) 0.01ms (+112%) 0.00% (NaN%)
relayed-udp-client2server 50.0 MiB (+0%) 0.08ms (-34%) 0.00% (NaN%)
relayed-udp-server2client 50.0 MiB (-0%) 0.05ms (-5%) 0.00% (NaN%)

@jamilbk jamilbk changed the title chore(connlib): Use non-fstat fork of tokio chore(connlib): Add PrivacyManifest Mar 30, 2024
@jamilbk jamilbk marked this pull request as ready for review March 30, 2024 05:40
@jamilbk
Copy link
Member Author

jamilbk commented Mar 30, 2024

I successfully tested this build with Apple and have not received an App Store error, so going to merge this since it's a blocker for publishing.

@jamilbk jamilbk merged commit 97d4d77 into main Mar 30, 2024
153 checks passed
@jamilbk jamilbk deleted the fix/privacy branch March 30, 2024 06:28
@jamilbk jamilbk changed the title chore(connlib): Add PrivacyManifest chore(apple): Add PrivacyManifest Mar 30, 2024
@ReactorScram
Copy link
Collaborator

Darn :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NetworkExtension uses NSPrivacyAccessedAPICategoryFileTimestamp causing App Store hurdle
2 participants