Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Everyone group preselected when creating Actor / adding to groups #4937

Closed
jamilbk opened this issue May 9, 2024 · 0 comments · Fixed by #4946
Closed

Show Everyone group preselected when creating Actor / adding to groups #4937

jamilbk opened this issue May 9, 2024 · 0 comments · Fixed by #4946
Labels
area/portal Portal, panel, web, control plane, you name it! kind/bug Something isn't working kind/UI Changes related specifically to the admin portal UI kind/UX Changes related specifically to overall user experience and product quality

Comments

@jamilbk
Copy link
Member

jamilbk commented May 9, 2024

And fix the alert confirmation dialog

Screenshot 2024-05-09 at 10 54 13 AM
@jamilbk jamilbk added kind/bug Something isn't working kind/UI Changes related specifically to the admin portal UI area/portal Portal, panel, web, control plane, you name it! kind/UX Changes related specifically to overall user experience and product quality labels May 9, 2024
@jamilbk jamilbk mentioned this issue May 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 10, 2024
@jamilbk
fix(portal): don't confirm group selections if there aren't changes (#…
e03340b 
…4946)

- Fixes #4937 (not worth adding complexity to the live table for this,
so just added as a note in the bottom)
- Don't show confirmation dialog if no changes have been made

<img width="912" alt="Screenshot 2024-05-09 at 11 03 00 PM"
src="https://github.com/firezone/firezone/assets/167144/47f1a76c-5f2a-4815-b0ff-7f1e68c785bf">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/portal Portal, panel, web, control plane, you name it! kind/bug Something isn't working kind/UI Changes related specifically to the admin portal UI kind/UX Changes related specifically to overall user experience and product quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(portal): don't confirm group selections if there aren't changes firezone/firezone
1 participant
@jamilbk