Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(portal): don't confirm group selections if there aren't changes #4946

Merged
merged 2 commits into from
May 10, 2024
Merged

fix(portal): don't confirm group selections if there aren't changes #4946

merged 2 commits into from
May 10, 2024

Conversation

jamilbk
Copy link
Member

@jamilbk jamilbk commented May 10, 2024 •
edited

Screenshot 2024-05-09 at 11 03 00 PM

@jamilbk jamilbk requested a review from bmanifold May 10, 2024 06:05
@vercel Vercel
Copy link

vercel bot commented May 10, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview May 10, 2024 2:20pm

@jamilbk jamilbk requested a review from AndrewDryga May 10, 2024 06:05
@github-actions github-actions bot added the kind/bug Something isn't working label May 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 10, 2024 •
edited

Terraform Cloud Plan Output

Plan: 15 to add, 15 to change, 15 to destroy.

Terraform Cloud Plan

@github-actions GitHub Actions
Copy link

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 237.7 MiB (-1%) 239.1 MiB (-2%) 274 (-10%)
direct-tcp-server2client 238.1 MiB (-2%) 239.4 MiB (-2%) 204 (-51%)
relayed-tcp-client2server 223.4 MiB (-1%) 224.3 MiB (-1%) 217 (+1%)
relayed-tcp-server2client 245.7 MiB (+5%) 246.2 MiB (+5%) 416 (+5%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (-0%) 0.04ms (+12%) 41.03% (-2%)
direct-udp-server2client 500.0 MiB (-0%) 0.01ms (-11%) 21.35% (-2%)
relayed-udp-client2server 500.0 MiB (+0%) 0.06ms (+95%) 56.66% (+2%)
relayed-udp-server2client 500.0 MiB (+0%) 0.09ms (-47%) 40.86% (-9%)

bmanifold
bmanifold approved these changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@bmanifold bmanifold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamilbk jamilbk enabled auto-merge May 10, 2024 06:53
@jamilbk jamilbk added this pull request to the merge queue May 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch May 10, 2024
@jamilbk jamilbk enabled auto-merge May 10, 2024 14:20
@jamilbk jamilbk added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit e03340b May 10, 2024
119 of 120 checks passed
@jamilbk jamilbk deleted the fix/everyone-group branch May 10, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewDryga AndrewDryga AndrewDryga approved these changes

@bmanifold bmanifold bmanifold approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show Everyone group preselected when creating Actor / adding to groups
3 participants
@jamilbk @AndrewDryga @bmanifold