Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code highlighting for React MDX #5057

Closed
jamilbk opened this issue May 21, 2024 · 0 comments · Fixed by #5058
Closed

Fix code highlighting for React MDX #5057

jamilbk opened this issue May 21, 2024 · 0 comments · Fixed by #5058
Assignees
@jamilbk
Labels
area/website Issues involving the firezone.dev website kind/docs Improvements or updates to documentation kind/UX Changes related specifically to overall user experience and product quality

Comments

@jamilbk
Copy link
Member

jamilbk commented May 21, 2024 •
edited

  • Fix ugliness / background for code highlighting blocks in MDX
  • Remove CodeBlock component. We can re-add it for sections of the website where we need code blocks outside of MDX

#5007 (comment)
@jamilbk jamilbk mentioned this issue May 21, 2024
Merged
@jamilbk jamilbk self-assigned this May 21, 2024
@jamilbk jamilbk added kind/docs Improvements or updates to documentation area/website Issues involving the firezone.dev website kind/UX Changes related specifically to overall user experience and product quality labels May 21, 2024
@jamilbk jamilbk mentioned this issue May 21, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 21, 2024
@jamilbk @ReactorScram
docs: Fix code block styling (#5058)
37ed0c8 
Fixes the styling bug that occurs when we use triple backticks to define
code blocks in markdown.

Now it looks like this:

<img width="936" alt="Screenshot 2024-05-20 at 10 55 56 PM"
src="https://github.com/firezone/firezone/assets/167144/36e88908-9023-4b91-82e4-c31d937dc015">


## NOTE

You *must* specify a language to use for highlighting, or `text` if
plaintext. Otherwise, no codeblock colorizing will occur.

Fixes #5057

---------

Co-authored-by: Not Applicable <ReactorScram@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamilbk jamilbk

Labels
area/website Issues involving the firezone.dev website kind/docs Improvements or updates to documentation kind/UX Changes related specifically to overall user experience and product quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Fix code block styling firezone/firezone
1 participant
@jamilbk