-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix code block styling #5058
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Terraform Cloud Plan Output
|
Performance Test ResultsTCP
UDP
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -385,7 +385,8 @@ works the same for any third-party SaaS service. | |||
|
|||
1. An admin defines a DNS Resource with address `*.slack.com` in the Firezone | |||
admin portal. Notice the wildcard -- this will route all subdomains for Slack | |||
through Firezone as well, which helps ensure all relevant Slack traffic is routed. | |||
through Firezone as well, which helps ensure all relevant Slack traffic is | |||
routed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a hard word wrap I should set in my editors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I use prettier set at 80, but it's not a hard requirement. Wrapping markdown is handled to varying degrees of success depending on the editor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just like to avoid like 200 line markdown paragraphs if possible.
@@ -370,7 +369,7 @@ export default function Page() { | |||
</ChromeIcon> | |||
</div> | |||
<div className="p-4 flex items-center justify-center bg-white rounded-lg border border-2 border-neutral-200"> | |||
<AppleIcon size={12} href="/kb/user-guides/macos-client"> | |||
<AppleIcon size={12} href="/kb/user-guides/ios-client"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the Apple Clients used to share one page and then they split into macOS and iOS? the iOS link was still pointed to macOS so I fixed that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They both still say "Apple Clients" though
Fixes the styling bug that occurs when we use triple backticks to define code blocks in markdown.
Now it looks like this:
NOTE
You must specify a language to use for highlighting, or
text
if plaintext. Otherwise, no codeblock colorizing will occur.Fixes #5057