Small improvements to make setup process easier for OS contributors #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For umbrella apps everything goes into /_build directory so there no need to ignore directories that should never be created
…pect 1. We want ecto.create and ecto.migrate to be run on each tests, this will simplify setup steps (no need to run migrations manually) 2. ecto.remigrate is not needed because now you can just run ecto.drop and on tests migrations would be executed anyways.
|
Should I remove or update |
|
Does anyone have a hint where this is coming from on each UPD: Found it: https://github.com/firezone/firezone/blob/master/config/dev.exs#L34. |
|
Wow — thanks for the contribution! Traveling today but should have some time to review later.
It may be better to rename the script |
Pull Request Test Coverage Report for Build 82465e91e97b323bb93611e7866abb85a93e7b7a-PR-1171
💛 - Coveralls |
AndrewDryga
changed the title
This an is opinionated change. Right now devcontainer doesn't work but should be easy to fix (with renaming step name), but at the same time it forces developers that use VS code to have unified development environment (including plugins for the editor itself). I feel like it's not a good path to go for OS and for small team - everyone should be allowed to use setup they like. Especially for people like me that tend to recompile ls-elixir for Elixir plugin from master branch. Plus it's yet another thing to maintain while nobody on the team is using it, which means it will be always causing issues.
Otherwise I'm getting this on my MacOS (that has a `route` implementation that doesn't show interfaces) when `mix phx.server` is executed: ``` usage: route [-dnqtv] command [[modifiers] args] ```
Both public_key and name are unique and we should not use static values for field covered by unique index, otherwise deadlocks and slow tests are expected.
The changeset code doesn't have any code that accesses the database and individual Ecto.SQL commands are already wrapped in transactions by default, so there is no need to start it manually and hold for longer than expected (while irrelevant Elixir code is running).
AndrewDryga
force-pushed
the
andrew/os-quality-of-life-improvements
branch
from
7d18f7f
to
bc354ca
Compare
AndrewDryga
changed the title
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasoning on each change please see the commit messages.