Fix external trusted proxies env usage #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3d699c240ed22827bcd71f44917e04bd1748b6c9-PR-1450
💛 - Coveralls |
AndrewDryga
commented
Feb 22, 2023
| @@ -9,12 +9,12 @@ defmodule FzHttpWeb.HeaderHelpers do | |||
|
|
|||
| def clients, do: FzHttp.Config.fetch_env!(:fz_http, :private_clients) | |||
|
|
|||
| def proxied?, do: not (external_trusted_proxies() == false) | |||
| def proxied?, do: external_trusted_proxies() != [] | |||
There was a problem hiding this comment.
@jamilbk the old condition never returned false, because it was always comparing a list to a boolean: [] == false.
There was a problem hiding this comment.
I just noticed this too. Thanks for the fix and test!
jamilbk
approved these changes
Feb 22, 2023
| @@ -9,12 +9,12 @@ defmodule FzHttpWeb.HeaderHelpers do | |||
|
|
|||
| def clients, do: FzHttp.Config.fetch_env!(:fz_http, :private_clients) | |||
|
|
|||
| def proxied?, do: not (external_trusted_proxies() == false) | |||
| def proxied?, do: external_trusted_proxies() != [] | |||
There was a problem hiding this comment.
I just noticed this too. Thanks for the fix and test!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://discourse.firez.one/t/environment-variables-errors/440/4